Re: [PR] Add Grid View to new UI [airflow]
jscheffl commented on PR #45497: URL: https://github.com/apache/airflow/pull/45497#issuecomment-2614095717 > Good call on the mapped task stuff. I made an issue for it here: #45990 > > Would you be able to make a gif or video of the second behavior you described? I am having a hard time understanding or I can't replicate it yet locally Sorry for the delay, coming back post merge now. https://github.com/user-attachments/assets/76de8570-cee0-4260-9f71-56e4bef47aa3 Attached please find the recording. Just tested post merge on current main. Clicks are not visual but whenever I click a task cell you see the runs are getting re-sorted by the length of the bars of DAG runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
bbovenzi merged PR #45497: URL: https://github.com/apache/airflow/pull/45497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
tirkarthi commented on code in PR #45497:
URL: https://github.com/apache/airflow/pull/45497#discussion_r1929412509
##
airflow/ui/src/layouts/Details/DagRunSelect.tsx:
##
@@ -34,11 +34,13 @@ export const DagRunSelect = forwardRef((_,
ref) => {
const [searchParams] = useSearchParams();
const navigate = useNavigate();
+ const offset = parseInt(searchParams.get("offset") ?? "0", 10);
+
const { data, isLoading } = useGridServiceGridData(
{
dagId,
- limit: 14,
- offset: 0,
+ limit: 25,
Review Comment:
Ok, I didn't know that. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
bbovenzi commented on code in PR #45497:
URL: https://github.com/apache/airflow/pull/45497#discussion_r1929158034
##
airflow/ui/src/layouts/Details/DagRunSelect.tsx:
##
@@ -34,11 +34,13 @@ export const DagRunSelect = forwardRef((_,
ref) => {
const [searchParams] = useSearchParams();
const navigate = useNavigate();
+ const offset = parseInt(searchParams.get("offset") ?? "0", 10);
+
const { data, isLoading } = useGridServiceGridData(
{
dagId,
- limit: 14,
- offset: 0,
+ limit: 25,
Review Comment:
We might delete that config value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
bbovenzi commented on code in PR #45497:
URL: https://github.com/apache/airflow/pull/45497#discussion_r1929157323
##
airflow/ui/src/layouts/Details/Graph/TaskNode.tsx:
##
@@ -58,7 +58,7 @@ export const TaskNode = ({
Re: [PR] Add Grid View to new UI [airflow]
pierrejeambrun commented on code in PR #45497:
URL: https://github.com/apache/airflow/pull/45497#discussion_r1929011574
##
airflow/ui/src/layouts/Details/Graph/TaskNode.tsx:
##
@@ -58,7 +58,7 @@ export const TaskNode = ({
Re: [PR] Add Grid View to new UI [airflow]
tirkarthi commented on code in PR #45497:
URL: https://github.com/apache/airflow/pull/45497#discussion_r1927950396
##
airflow/ui/src/layouts/Details/DagRunSelect.tsx:
##
@@ -34,11 +34,13 @@ export const DagRunSelect = forwardRef((_,
ref) => {
const [searchParams] = useSearchParams();
const navigate = useNavigate();
+ const offset = parseInt(searchParams.get("offset") ?? "0", 10);
+
const { data, isLoading } = useGridServiceGridData(
{
dagId,
- limit: 14,
- offset: 0,
+ limit: 25,
Review Comment:
This can be set using config API value.
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#default-dag-run-display-number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
bbovenzi commented on PR #45497: URL: https://github.com/apache/airflow/pull/45497#issuecomment-2611176628 Good call on the mapped task stuff. I made an issue for it here: https://github.com/apache/airflow/issues/45990 Would you be able to make a gif or video of the second behavior you described? I am having a hard time understanding or I can't replicate it yet locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
jscheffl commented on PR #45497: URL: https://github.com/apache/airflow/pull/45497#issuecomment-2610845678 Also second had "strange" results in the example task group, when I selected tasks in a group my browser (Firefox, Ubuntu 24.04 LTS) was sorting the runs and selecting the first execution if I clicked on the task of second/third run:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Grid View to new UI [airflow]
jscheffl commented on PR #45497: URL: https://github.com/apache/airflow/pull/45497#issuecomment-2610835193 Did a small "smoke test" - if you select a mapped task and close the grid, the selected task navigation throws an error:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Grid View to new UI [airflow]
bbovenzi opened a new pull request, #45497:
URL: https://github.com/apache/airflow/pull/45497
https://github.com/user-attachments/assets/2c162b1d-4b9b-46c9-b606-80eb7cf609ef";
/>
https://github.com/user-attachments/assets/d34541c8-7733-43a3-88c8-068f8cede700";
/>
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
