Re: [PR] Adding `run_after` field in task SDK datamodels [airflow]

2025-02-05 Thread via GitHub


potiuk commented on PR #46492:
URL: https://github.com/apache/airflow/pull/46492#issuecomment-2639089755

   NICE! COOL @amoghrajesh !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Adding `run_after` field in task SDK datamodels [airflow]

2025-02-05 Thread via GitHub


amoghrajesh merged PR #46492:
URL: https://github.com/apache/airflow/pull/46492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Adding `run_after` field in task SDK datamodels [airflow]

2025-02-05 Thread via GitHub


amoghrajesh commented on PR #46492:
URL: https://github.com/apache/airflow/pull/46492#issuecomment-2638779090

   Okay got this one through!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Adding `run_after` field in task SDK datamodels [airflow]

2025-02-05 Thread via GitHub


amoghrajesh closed pull request #46492: Adding `run_after` field in task SDK 
datamodels
URL: https://github.com/apache/airflow/pull/46492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] Adding `run_after` field in task SDK datamodels [airflow]

2025-02-05 Thread via GitHub


amoghrajesh opened a new pull request, #46492:
URL: https://github.com/apache/airflow/pull/46492

   
   
   
   
   
   All K8s tests started failing in 
https://github.com/apache/airflow/actions/runs/13158509534.
   
   When traced down, this is the error:
   ```
   2025-02-05T14:49:01.975482931Z stdout F [2025-02-05T14:49:01.975+] 
{_trace.py:47} DEBUG - receive_response_body.started request=
   2025-02-05T14:49:01.975742808Z stdout F 2025-02-05 14:49:01 [info ] 
Process exited [supervisor] exit_code= 
pid=155 signal=SIGKILL
   2025-02-05T14:49:01.977567917Z stdout F [2025-02-05T14:49:01.976+] 
{local_executor.py:99} ERROR - uhoh
   2025-02-05T14:49:01.977577034Z stdout F Traceback (most recent call last):
   2025-02-05T14:49:01.977581732Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/airflow/executors/local_executor.py",
 line 95, in _run_worker
   2025-02-05T14:49:01.977586171Z stdout F _execute_work(log, workload)
   2025-02-05T14:49:01.977590339Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/airflow/executors/local_executor.py",
 line 116, in _execute_work
   2025-02-05T14:49:01.977594466Z stdout F supervise(
   2025-02-05T14:49:01.977598674Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/execution_time/supervisor.py",
 line 970, in supervise
   2025-02-05T14:49:01.977602662Z stdout F process = 
ActivitySubprocess.start(
   2025-02-05T14:49:01.977606619Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/execution_time/supervisor.py",
 line 602, in start
   2025-02-05T14:49:01.977620685Z stdout F proc._on_child_started(ti=what, 
dag_rel_path=dag_rel_path, bundle_info=bundle_info)
   2025-02-05T14:49:01.977625254Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/execution_time/supervisor.py",
 line 611, in _on_child_started
   2025-02-05T14:49:01.977629722Z stdout F ti_context = 
self.client.task_instances.start(ti.id, self.pid, datetime.now(tz=timezone.utc))
   2025-02-05T14:49:01.97763392Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/airflow/sdk/api/client.py", 
line 133, in start
   2025-02-05T14:49:01.977638399Z stdout F return 
TIRunContext.model_validate_json(resp.read())
   2025-02-05T14:49:01.977642506Z stdout F   File 
"/home/airflow/.local/lib/python3.9/site-packages/pydantic/main.py", line 656, 
in model_validate_json
   2025-02-05T14:49:01.977647135Z stdout F return 
cls.__pydantic_validator__.validate_json(json_data, strict=strict, 
context=context)
   2025-02-05T14:49:01.977651122Z stdout F 
pydantic_core._pydantic_core.ValidationError: 1 validation error for 
TIRunContext
   2025-02-05T14:49:01.977655821Z stdout F dag_run.run_after
   2025-02-05T14:49:01.97765Z stdout F   Extra inputs are not permitted 
[type=extra_forbidden, input_value='2025-02-05T00:00:00Z', input_type=str]
   2025-02-05T14:49:01.977664077Z stdout F For further information visit 
https://errors.pydantic.dev/2.10/v/extra_forbidden
   ```
   
   This makes https://github.com/apache/airflow/pull/45732 the obvious 
candidate but that was merged a couple days ago, we shouldve seen the failures 
earlier.
   
   But, https://github.com/apache/airflow/pull/44986 was merged recently which 
doesn't allow extra fields in any datamodels, due to which the fields added in 
the previous PR started screaming.
   
   This PR updates the fields in task sdk datamodels.
   
   
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]