Re: [PR] Alias run_after for XComResponse [airflow]
guan404ming commented on PR #61443: URL: https://github.com/apache/airflow/pull/61443#issuecomment-3871600045 Manual backport #61672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Alias run_after for XComResponse [airflow]
github-actions[bot] commented on PR #61443: URL: https://github.com/apache/airflow/pull/61443#issuecomment-3871437437 ### Backport failed to create: v3-1-test. View the failure log Run details Status Branch Result ❌ v3-1-test https://github.com/apache/airflow/commit/e8140016f0475054e8b8c91dbb92cd1d06054865";> You can attempt to backport this manually by running: ```bash cherry_picker e814001 v3-1-test ``` This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Alias run_after for XComResponse [airflow]
guan404ming commented on PR #61443: URL: https://github.com/apache/airflow/pull/61443#issuecomment-3871432626 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Alias run_after for XComResponse [airflow]
guan404ming merged PR #61443: URL: https://github.com/apache/airflow/pull/61443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Alias run_after for XComResponse [airflow]
guan404ming commented on code in PR #61443:
URL: https://github.com/apache/airflow/pull/61443#discussion_r2773905821
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -72,12 +72,12 @@ const getColumns = ({ open, translate }: ColumnsProps):
Array (
-
+
Review Comment:
> This probably should be a comoponent instead of a plain test.
> Maybe add a column instead of replacing ? So people used to it are not
confused?
That would better with those suggestions, thanks! Just updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Alias run_after for XComResponse [airflow]
pierrejeambrun commented on code in PR #61443:
URL: https://github.com/apache/airflow/pull/61443#discussion_r2770378587
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -72,12 +72,12 @@ const getColumns = ({ open, translate }: ColumnsProps):
Array (
-
+
Review Comment:
This probably should be a `` comoponent instead of a plain test.
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -72,12 +72,12 @@ const getColumns = ({ open, translate }: ColumnsProps):
Array (
-
+
Review Comment:
Maybe add a column instead of replacing ? So people used to it are not
confused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] Alias run_after for XComResponse [airflow]
guan404ming opened a new pull request, #61443:
URL: https://github.com/apache/airflow/pull/61443
## Related Issue
#46730
## How
- alias `run_after` for `XComResponse`
- update tests and ui usage
---
# Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
