Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
jedcunningham commented on PR #50435: URL: https://github.com/apache/airflow/pull/50435#issuecomment-2873762546 Feels like this might be better for 3.1 instead of 3.0.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
amoghrajesh commented on code in PR #50435: URL: https://github.com/apache/airflow/pull/50435#discussion_r2084096514 ## airflow-core/src/airflow/decorators/__init__.py: ## @@ -32,6 +30,7 @@ "DecoratedMappedOperator": "airflow.sdk.bases.decorator.DecoratedMappedOperator", "DecoratedOperator": "airflow.sdk.bases.decorator.DecoratedOperator", "TaskDecorator": "airflow.sdk.bases.decorator.TaskDecorator", +"TaskDecoratorCollection": "airflow.sdk.bases.decorator.TaskDecoratorCollection", Review Comment: Oh boy. Good catch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
kaxil commented on code in PR #50435: URL: https://github.com/apache/airflow/pull/50435#discussion_r2084079594 ## airflow-core/src/airflow/decorators/__init__.py: ## @@ -32,6 +30,7 @@ "DecoratedMappedOperator": "airflow.sdk.bases.decorator.DecoratedMappedOperator", "DecoratedOperator": "airflow.sdk.bases.decorator.DecoratedOperator", "TaskDecorator": "airflow.sdk.bases.decorator.TaskDecorator", +"TaskDecoratorCollection": "airflow.sdk.bases.decorator.TaskDecoratorCollection", Review Comment: That is wrong import! ```suggestion "TaskDecorator": "airflow.sdk.bases.decorator.TaskDecorator", "TaskDecoratorCollection": "airflow.sdk.definitions.decorators.TaskDecoratorCollection", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
amoghrajesh commented on code in PR #50435: URL: https://github.com/apache/airflow/pull/50435#discussion_r2084010372 ## airflow-core/src/airflow/decorators/__init__.py: ## @@ -16,15 +16,6 @@ # under the License. from __future__ import annotations -from airflow.sdk.definitions.decorators import ( -TaskDecorator as TaskDecorator, -TaskDecoratorCollection as TaskDecoratorCollection, Review Comment: Cool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
kaxil commented on code in PR #50435: URL: https://github.com/apache/airflow/pull/50435#discussion_r2083476359 ## airflow-core/src/airflow/decorators/__init__.py: ## @@ -16,15 +16,6 @@ # under the License. from __future__ import annotations -from airflow.sdk.definitions.decorators import ( -TaskDecorator as TaskDecorator, -TaskDecoratorCollection as TaskDecoratorCollection, Review Comment: Let's add `TaskDecoratorCollection` to `__deprecated_classes` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
amoghrajesh commented on code in PR #50435: URL: https://github.com/apache/airflow/pull/50435#discussion_r2083386066 ## airflow-core/src/airflow/decorators/__init__.py: ## @@ -16,15 +16,6 @@ # under the License. from __future__ import annotations -from airflow.sdk.definitions.decorators import ( -TaskDecorator as TaskDecorator, -TaskDecoratorCollection as TaskDecoratorCollection, Review Comment: Yep, accidentally removed them. Fixing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Avoid importing from sdk when deprecating using utils [airflow]
kaxil commented on code in PR #50435: URL: https://github.com/apache/airflow/pull/50435#discussion_r2083139083 ## airflow-core/src/airflow/decorators/__init__.py: ## @@ -16,15 +16,6 @@ # under the License. from __future__ import annotations -from airflow.sdk.definitions.decorators import ( -TaskDecorator as TaskDecorator, -TaskDecoratorCollection as TaskDecoratorCollection, Review Comment: We don't import dag, task, taskgroup, teardown and such via that util, it will break back-compat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Avoid importing from sdk when deprecating using utils [airflow]
amoghrajesh opened a new pull request, #50435:
URL: https://github.com/apache/airflow/pull/50435
We do not need to import it this way when we are anyways deprecating it
using `add_deprecated_classes`
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
