Re: [PR] Fix CloudComposerExternalTaskSensor success on empty execution window [airflow]
wtfashwin closed pull request #67257: Fix CloudComposerExternalTaskSensor success on empty execution window URL: https://github.com/apache/airflow/pull/67257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix CloudComposerExternalTaskSensor success on empty execution window [airflow]
shahar1 commented on PR #67257: URL: https://github.com/apache/airflow/pull/67257#issuecomment-4520611680 > As I see this PR is duplication for this one #67052 > > https://private-user-images.githubusercontent.com/12415200/596864103-35c35b88-4b4c-4fb7-b4d2-5b74834ec4b0.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzk0NjY0NjgsIm5iZiI6MTc3OTQ2NjE2OCwicGF0aCI6Ii8xMjQxNTIwMC81OTY4NjQxMDMtMzVjMzViODgtNGI0Yy00ZmI3LWI0ZDItNWI3NDgzNGVjNGIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA1MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNTIyVDE2MDkyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4NzY3NThjZDVjZDdkYWY4N2I1M2Q1MGMyYTVhNzgxOWQyMzA4Y2IyMzA4ZjdmNjBhNDY5YzAwZTY3M2M3ZjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.jWLxMn9bGeaO19l5bGfCfwbiN7lWpdE1ulIbNA9y9E4";> > @shahar1 what should we do in this case? Current approach is to allow raising multiple PRs for resolving an issue, and the first PR that becomes suitable for merging will be merged while the others will be closed. However, I do have some expectations when reviewing such "competitive" PRs: 1. The authors are aware of other existing ongoing attempts, **especially if they were reviewed**, and address their issues (in this case, running the system tests against a real Cloud Composer instance). 2. AI usage should be declared. I won't review this PR until the above conditions are met. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix CloudComposerExternalTaskSensor success on empty execution window [airflow]
MaksYermak commented on PR #67257: URL: https://github.com/apache/airflow/pull/67257#issuecomment-4520261312 As I see this PR is duplication for this one https://github.com/apache/airflow/pull/67052 https://github.com/user-attachments/assets/35c35b88-4b4c-4fb7-b4d2-5b74834ec4b0"; /> @shahar1 what should we do in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix CloudComposerExternalTaskSensor success on empty execution window [airflow]
boring-cyborg[bot] commented on PR #67257: URL: https://github.com/apache/airflow/pull/67257#issuecomment-4501464602 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Fix CloudComposerExternalTaskSensor success on empty execution window [airflow]
wtfashwin opened a new pull request, #67257:
URL: https://github.com/apache/airflow/pull/67257
CloudComposerExternalTaskSensor and CloudComposerExternalTaskTrigger
reported success whenever no in-window task instance was in a disallowed state.
When every returned task instance fell outside the requested execution_range,
the helper still returned success instead of continuing to wait for a relevant
in-window task instance.
_check_task_instances_states now only returns success when at least one task
instance is inside the requested window and all in-window task instances
satisfy the expected state set, mirroring the equivalent
CloudComposerDAGRunSensor fix.
closes: #67051
---
# Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
