Re: [PR] Fix get_task_instances typing: allow single items [airflow]
ashb merged PR #50757: URL: https://github.com/apache/airflow/pull/50757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix get_task_instances typing: allow single items [airflow]
boring-cyborg[bot] commented on PR #50757: URL: https://github.com/apache/airflow/pull/50757#issuecomment-3036435071 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix get_task_instances typing: allow single items [airflow]
gajop-ptx commented on PR #50757: URL: https://github.com/apache/airflow/pull/50757#issuecomment-3034033215 Can anyone take a look? It's a fairly trivial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix get_task_instances typing: allow single items [airflow]
github-actions[bot] commented on PR #50757: URL: https://github.com/apache/airflow/pull/50757#issuecomment-3033994412 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix get_task_instances typing: allow single items [airflow]
gajop-ptx opened a new pull request, #50757: URL: https://github.com/apache/airflow/pull/50757 --- The current implementation uses this argument in one place: - https://github.com/apache/airflow/blob/c86a4e1582fde083a4c93ea81955f586009177d1/airflow-core/src/airflow/models/dag.py#L890 - This invokes one of the three functions [[1](https://github.com/apache/airflow/blob/c86a4e1582fde083a4c93ea81955f586009177d1/airflow-core/src/airflow/models/dag.py#L899)], [[2](https://github.com/apache/airflow/blob/c86a4e1582fde083a4c93ea81955f586009177d1/airflow-core/src/airflow/models/dag.py#L915)], [[3](https://github.com/apache/airflow/blob/c86a4e1582fde083a4c93ea81955f586009177d1/airflow-core/src/airflow/models/dag.py#L934)], with the following type: `state: TaskInstanceState | Sequence[TaskInstanceState]` In other parts of the codebase, it's already used by passing a single item rather than a list. [REF](https://github.com/apache/airflow/blob/c86a4e1582fde083a4c93ea81955f586009177d1/airflow-core/src/airflow/ti_deps/dep_context.py#L96) PS: This is my first time contributing here, please let me know if the format of the PR or the commit message should look different. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix get_task_instances typing: allow single items [airflow]
boring-cyborg[bot] commented on PR #50757: URL: https://github.com/apache/airflow/pull/50757#issuecomment-2889579493 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
