Re: [PR] Fixed generated SQL MSSQL dialect when all columns are also primary keys [airflow]

2025-02-05 Thread via GitHub


potiuk merged PR #46380:
URL: https://github.com/apache/airflow/pull/46380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Fixed generated SQL MSSQL dialect when all columns are also primary keys [airflow]

2025-02-05 Thread via GitHub


dabla commented on PR #46380:
URL: https://github.com/apache/airflow/pull/46380#issuecomment-2636576532

   > Static checks are failing 
https://github.com/apache/airflow/actions/runs/13154423653/job/36708789726?pr=46380#step:6:218
   
   should be fixed now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Fixed generated SQL MSSQL dialect when all columns are also primary keys [airflow]

2025-02-05 Thread via GitHub


eladkal commented on PR #46380:
URL: https://github.com/apache/airflow/pull/46380#issuecomment-2636338297

   Static checks are failing 
https://github.com/apache/airflow/actions/runs/13154423653/job/36708789726?pr=46380#step:6:218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] Fixed generated SQL MSSQL dialect when all columns are also primary keys [airflow]

2025-02-03 Thread via GitHub


dabla opened a new pull request, #46380:
URL: https://github.com/apache/airflow/pull/46380

   This PR fixes the case when all columns are also primary keys when 
generating the replace SQL statement for MS SQL.
   
   
   
   
   
   
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]