Re: [PR] Making PMC testing instructions more explicit [airflow]
amoghrajesh commented on code in PR #52903: URL: https://github.com/apache/airflow/pull/52903#discussion_r2187102387 ## dev/README_RELEASE_PROVIDERS.md: ## @@ -757,7 +757,7 @@ script to verify that all expected files are present in SVN. This script will pr may help with verifying installation of the packages. ```shell script -# Copy the list of packages (pypi urls) into `packages.txt` then run: +# Copy the list of packages (pypi urls) from email into a `packages.txt` then run: Review Comment: @potiuk I pushed another change as well to make it somewhat explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Making PMC testing instructions more explicit [airflow]
amoghrajesh commented on code in PR #52903: URL: https://github.com/apache/airflow/pull/52903#discussion_r2187062666 ## dev/README_RELEASE_PROVIDERS.md: ## @@ -757,7 +757,7 @@ script to verify that all expected files are present in SVN. This script will pr may help with verifying installation of the packages. ```shell script -# Copy the list of packages (pypi urls) into `packages.txt` then run: +# Copy the list of packages (pypi urls) from email into a `packages.txt` then run: Review Comment: Yeah sure, in a bit :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Making PMC testing instructions more explicit [airflow]
potiuk commented on code in PR #52903: URL: https://github.com/apache/airflow/pull/52903#discussion_r2187056195 ## dev/README_RELEASE_PROVIDERS.md: ## @@ -757,7 +757,7 @@ script to verify that all expected files are present in SVN. This script will pr may help with verifying installation of the packages. ```shell script -# Copy the list of packages (pypi urls) into `packages.txt` then run: +# Copy the list of packages (pypi urls) from email into a `packages.txt` then run: Review Comment: Maybe make it also into an actual step to do ? When it's in the comment I subconsciously don't read it when I am following instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Making PMC testing instructions more explicit [airflow]
amoghrajesh opened a new pull request, #52903:
URL: https://github.com/apache/airflow/pull/52903
It wasn't too explicit to me atleast, i was trying to copy from svn link and
wasn't sure of the format either
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
