Re: [PR] Refactor API side of "reparse DAG" feature to support bundles [airflow]
jedcunningham commented on code in PR #48216: URL: https://github.com/apache/airflow/pull/48216#discussion_r2012582869 ## airflow-core/src/airflow/migrations/versions/0064_3_0_0_support_bundles_in_.py: ## @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Support bundles in DagPriorityParsingRequest. + +Revision ID: be2cc2f742cf +Revises: d469d27e2a64 +Create Date: 2025-03-13 00:16:31.011374 +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op + +# revision identifiers, used by Alembic. +revision = "be2cc2f742cf" Review Comment: Maybe not literally 1 - that'd be a pain to maintain. But, combining where it makes sense is definitely reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Refactor API side of "reparse DAG" feature to support bundles [airflow]
kaxil commented on code in PR #48216: URL: https://github.com/apache/airflow/pull/48216#discussion_r2012574257 ## airflow-core/src/airflow/migrations/versions/0064_3_0_0_support_bundles_in_.py: ## @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Support bundles in DagPriorityParsingRequest. + +Revision ID: be2cc2f742cf +Revises: d469d27e2a64 +Create Date: 2025-03-13 00:16:31.011374 +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op + +# revision identifiers, used by Alembic. +revision = "be2cc2f742cf" Review Comment: unrelated: should we squash DB migration before 3.0 .. ie. merge them into 1 where they are net new migration between 2.10.x and 3.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Refactor API side of "reparse DAG" feature to support bundles [airflow]
jedcunningham merged PR #48216: URL: https://github.com/apache/airflow/pull/48216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Refactor API side of "reparse DAG" feature to support bundles [airflow]
kaxil commented on code in PR #48216: URL: https://github.com/apache/airflow/pull/48216#discussion_r2012589839 ## airflow-core/src/airflow/migrations/versions/0064_3_0_0_support_bundles_in_.py: ## @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Support bundles in DagPriorityParsingRequest. + +Revision ID: be2cc2f742cf +Revises: d469d27e2a64 +Create Date: 2025-03-13 00:16:31.011374 +""" + +from __future__ import annotations + +import sqlalchemy as sa +from alembic import op + +# revision identifiers, used by Alembic. +revision = "be2cc2f742cf" Review Comment: > ie. merge them into 1 Oh yeah, I meant into logical groups. Example: dag bundle ones can be a single migration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Refactor API side of "reparse DAG" feature to support bundles [airflow]
jedcunningham opened a new pull request, #48216: URL: https://github.com/apache/airflow/pull/48216 This refactors the API side of the "reparse DAG" feature to support bundles. We now pass the bundle name and the relative file path to the api endpoint - however, as this is all in the "file token", the behavior for users is unchanged between Airflow 2 and Airflow 3. This also changes the `DagPriorityParsingRequest` to have both bundle name and relative path instead of a just fileloc. A follow up will get the dag processor consuming these requests again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
