Re: [PR] Remove Marshmallow from Core [airflow]
uranusjr merged PR #49388: URL: https://github.com/apache/airflow/pull/49388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove Marshmallow from Core [airflow]
aritra24 commented on code in PR #49388: URL: https://github.com/apache/airflow/pull/49388#discussion_r2050317196 ## providers/amazon/pyproject.toml: ## @@ -79,6 +79,7 @@ dependencies = [ # We can remove it after https://github.com/xmlsec/python-xmlsec/issues/344 is fixed "xmlsec!=1.3.15,>=1.3.14", "sagemaker-studio>=1.0.9", +"marshmallow>=3", Review Comment: Ah, ack! Makes sense. Thanks for the explanation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove Marshmallow from Core [airflow]
uranusjr commented on code in PR #49388: URL: https://github.com/apache/airflow/pull/49388#discussion_r2050295911 ## providers/amazon/pyproject.toml: ## @@ -79,6 +79,7 @@ dependencies = [ # We can remove it after https://github.com/xmlsec/python-xmlsec/issues/344 is fixed "xmlsec!=1.3.15,>=1.3.14", "sagemaker-studio>=1.0.9", +"marshmallow>=3", Review Comment: The Amazon provider has been using Marshmallow without declaring an explicit dependency. This has been working since providers depend on Airflow Core, and Core uses Marshmallow in the REST API (prior to 3.0). With this PR removing Marshmallow entirely from Core, the provider needs to declare the dependency explicitly. (Also, since we did not notice this implicit dependency in time, the Amazon provider of a non-up-to-date version may break out of the box if you use it with Airflow 3.0. This is unfortunate, but we can’t go back and fix old provider releases. At least you can easily fix this by manually installing Marshmallow.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove Marshmallow from Core [airflow]
aritra24 commented on code in PR #49388: URL: https://github.com/apache/airflow/pull/49388#discussion_r2049405028 ## providers/amazon/pyproject.toml: ## @@ -79,6 +79,7 @@ dependencies = [ # We can remove it after https://github.com/xmlsec/python-xmlsec/issues/344 is fixed "xmlsec!=1.3.15,>=1.3.14", "sagemaker-studio>=1.0.9", +"marshmallow>=3", Review Comment: Why was this addition needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove Marshmallow from Core [airflow]
ephraimbuddy commented on PR #49388: URL: https://github.com/apache/airflow/pull/49388#issuecomment-2812453514 We still have marshmallow here: https://github.com/apache/airflow/blob/04dabf45a60ec55fe715c41bbd8594d0390adf3b/airflow-core/src/airflow/cli/commands/dag_command.py#L36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] Remove Marshmallow from Core [airflow]
uranusjr opened a new pull request, #49388: URL: https://github.com/apache/airflow/pull/49388 Switch the last standing usage in CLI to use Pydantic instead. I think we can drop the dependency outright now? Let's see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Remove Marshmallow from Core [airflow]
pierrejeambrun commented on PR #49388: URL: https://github.com/apache/airflow/pull/49388#issuecomment-2812301344 LGTM supposing the CI agrees :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
