Re: [PR] Update Helm eviction configuration guide to reflect `workers.safeToEvict` default value [airflow]

2025-01-02 Thread via GitHub


jedcunningham commented on PR #44852:
URL: https://github.com/apache/airflow/pull/44852#issuecomment-2568713123

   Good catch, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update Helm eviction configuration guide to reflect `workers.safeToEvict` default value [airflow]

2025-01-02 Thread via GitHub


jedcunningham merged PR #44852:
URL: https://github.com/apache/airflow/pull/44852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Update Helm eviction configuration guide to reflect `workers.safeToEvict` default value [airflow]

2024-12-11 Thread via GitHub


sean-rose opened a new pull request, #44852:
URL: https://github.com/apache/airflow/pull/44852

   The `workers.safeToEvict` default value was changed to `false` in #40229 and 
the Helm chart guide should reflect that.
   
   related: #40229
   
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org