Re: [PR] Update README_AIRFLOW3_DEV.md [airflow]
potiuk merged PR #50444: URL: https://github.com/apache/airflow/pull/50444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update README_AIRFLOW3_DEV.md [airflow]
shahar1 opened a new pull request, #50444:
URL: https://github.com/apache/airflow/pull/50444
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update README_AIRFLOW3_DEV.md [airflow]
potiuk merged PR #44304: URL: https://github.com/apache/airflow/pull/44304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update README_AIRFLOW3_DEV.md [airflow]
rawwar commented on code in PR #44304: URL: https://github.com/apache/airflow/pull/44304#discussion_r1855194189 ## dev/README_AIRFLOW3_DEV.md: ## @@ -58,29 +58,33 @@ PRs should target `main` branch. Make sure your code is only about Providers or Helm chart. Avoid mixing core changes into the same PR +> [!NOTE] +> Please note that providers have been relocated from `airflow/providers` to `providers/src/airflow/providers`. + ## Developing for Airflow 3 and 2.10.x / 2.11.x If the PR is relevant for both Airflow 3 and 2, it should target `main` branch. -Note: The mental model of Airflow 2.11 is bridge release for Airflow 3. -As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. -That said, we recognize that there may be exceptions. -If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as discussion thread on the mailing list. -Points to address to make your case: - -1. You must clarify what is the urgency (i.e., why it can't wait for Airflow 3). -2. You need be willing to deliver the feature for both main branch and Airflow 2.11 branch. -3. You must be willing to provide support future bug fixes as needed. - -Points to consider on how PMC members evaluate the request of exception: - -1. Feature impact - Is it really urgent? How many are affected? -2. Workarounds - Are there any ? -3. Scope of change - Both in code lines / number of files and components changed. -4. Centrality - Is the feature at the heart of Airflow (scheduler, dag parser) or peripheral. -5. Identity of the requester - Is the request from/supported by a member of the community? -6. Similar previous cases approved. -7. Other considerations that may raise by PMC members depending on the case. +> [!IMPORTANT] +> The mental model of Airflow 2.11 is bridge release for Airflow 3. +> As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. +> That said, we recognize that there may be exceptions. +> If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as discussion thread on the mailing list. +> Points to address to make your case: +> +> 1. You must clarify what is the urgency (i.e., why it can't wait for Airflow 3). +> 2. You need be willing to deliver the feature for both `main` branch and Airflow 2.11 branch. +> 3. You must be willing to provide support future bug fixes as needed. +> +> Points to consider on how PMC members evaluate the request of exception: +> +> 1. Feature impact - Is it really urgent? How many are affected? +> 2. Workarounds - Are there any ? +> 3. Scope of change - Both in code lines / number of files and components changed. +> 4. Centrality - Is the feature at the heart of Airflow (scheduler, dag parser) or peripheral. +> 5. Identity of the requester - Is the request from/supported by a member of the community? +> 6. Similar previous cases approved. +> 7. Other considerations that may raise by PMC members depending on the case. Review Comment: ```suggestion > 1. You must clarify the urgency, specifically why it can't wait for Airflow 3. > 2. You need to be willing to deliver the feature for both the `main` branch and the Airflow 2.11 branch. > 3. You must be willing to provide support for future bug fixes as needed. > > Points to consider on how PMC members evaluate the request for exception: > > 1. Feature impact - Is it really urgent? How many are affected? > 2. Workarounds - Are there any? > 3. Scope of change - Both in code lines / number of files and components changed. > 4. Centrality - Is the feature at the heart of Airflow (scheduler, dag parser) or peripheral. > 5. Identity of the requester - Is the request from/supported by a member of the community? > 6. Approved cases with similar details in the past. > 7. Other considerations that may be raised by PMC members depending on the case. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update README_AIRFLOW3_DEV.md [airflow]
rawwar commented on code in PR #44304: URL: https://github.com/apache/airflow/pull/44304#discussion_r1855193551 ## dev/README_AIRFLOW3_DEV.md: ## @@ -58,29 +58,33 @@ PRs should target `main` branch. Make sure your code is only about Providers or Helm chart. Avoid mixing core changes into the same PR +> [!NOTE] +> Please note that providers have been relocated from `airflow/providers` to `providers/src/airflow/providers`. + ## Developing for Airflow 3 and 2.10.x / 2.11.x If the PR is relevant for both Airflow 3 and 2, it should target `main` branch. -Note: The mental model of Airflow 2.11 is bridge release for Airflow 3. -As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. -That said, we recognize that there may be exceptions. -If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as discussion thread on the mailing list. -Points to address to make your case: - -1. You must clarify what is the urgency (i.e., why it can't wait for Airflow 3). -2. You need be willing to deliver the feature for both main branch and Airflow 2.11 branch. -3. You must be willing to provide support future bug fixes as needed. - -Points to consider on how PMC members evaluate the request of exception: - -1. Feature impact - Is it really urgent? How many are affected? -2. Workarounds - Are there any ? -3. Scope of change - Both in code lines / number of files and components changed. -4. Centrality - Is the feature at the heart of Airflow (scheduler, dag parser) or peripheral. -5. Identity of the requester - Is the request from/supported by a member of the community? -6. Similar previous cases approved. -7. Other considerations that may raise by PMC members depending on the case. +> [!IMPORTANT] +> The mental model of Airflow 2.11 is bridge release for Airflow 3. +> As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. +> That said, we recognize that there may be exceptions. +> If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as discussion thread on the mailing list. Review Comment: ```suggestion > If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as a discussion thread on the mailing list. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update README_AIRFLOW3_DEV.md [airflow]
rawwar commented on code in PR #44304: URL: https://github.com/apache/airflow/pull/44304#discussion_r1855193467 ## dev/README_AIRFLOW3_DEV.md: ## @@ -58,29 +58,33 @@ PRs should target `main` branch. Make sure your code is only about Providers or Helm chart. Avoid mixing core changes into the same PR +> [!NOTE] +> Please note that providers have been relocated from `airflow/providers` to `providers/src/airflow/providers`. + ## Developing for Airflow 3 and 2.10.x / 2.11.x If the PR is relevant for both Airflow 3 and 2, it should target `main` branch. -Note: The mental model of Airflow 2.11 is bridge release for Airflow 3. -As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. -That said, we recognize that there may be exceptions. -If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as discussion thread on the mailing list. -Points to address to make your case: - -1. You must clarify what is the urgency (i.e., why it can't wait for Airflow 3). -2. You need be willing to deliver the feature for both main branch and Airflow 2.11 branch. -3. You must be willing to provide support future bug fixes as needed. - -Points to consider on how PMC members evaluate the request of exception: - -1. Feature impact - Is it really urgent? How many are affected? -2. Workarounds - Are there any ? -3. Scope of change - Both in code lines / number of files and components changed. -4. Centrality - Is the feature at the heart of Airflow (scheduler, dag parser) or peripheral. -5. Identity of the requester - Is the request from/supported by a member of the community? -6. Similar previous cases approved. -7. Other considerations that may raise by PMC members depending on the case. +> [!IMPORTANT] +> The mental model of Airflow 2.11 is bridge release for Airflow 3. +> As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. Review Comment: ```suggestion > As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant to the bridge release for Airflow 3. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update README_AIRFLOW3_DEV.md [airflow]
rawwar commented on code in PR #44304: URL: https://github.com/apache/airflow/pull/44304#discussion_r1855193416 ## dev/README_AIRFLOW3_DEV.md: ## @@ -58,29 +58,33 @@ PRs should target `main` branch. Make sure your code is only about Providers or Helm chart. Avoid mixing core changes into the same PR +> [!NOTE] +> Please note that providers have been relocated from `airflow/providers` to `providers/src/airflow/providers`. + ## Developing for Airflow 3 and 2.10.x / 2.11.x If the PR is relevant for both Airflow 3 and 2, it should target `main` branch. -Note: The mental model of Airflow 2.11 is bridge release for Airflow 3. -As a result, Airflow 2.11 is not planned to introduce new features other than ones relevant as bridge release for Airflow 3. -That said, we recognize that there may be exceptions. -If you believe a specific feature is a must-have for Airflow 2.11, you will need to raise this as discussion thread on the mailing list. -Points to address to make your case: - -1. You must clarify what is the urgency (i.e., why it can't wait for Airflow 3). -2. You need be willing to deliver the feature for both main branch and Airflow 2.11 branch. -3. You must be willing to provide support future bug fixes as needed. - -Points to consider on how PMC members evaluate the request of exception: - -1. Feature impact - Is it really urgent? How many are affected? -2. Workarounds - Are there any ? -3. Scope of change - Both in code lines / number of files and components changed. -4. Centrality - Is the feature at the heart of Airflow (scheduler, dag parser) or peripheral. -5. Identity of the requester - Is the request from/supported by a member of the community? -6. Similar previous cases approved. -7. Other considerations that may raise by PMC members depending on the case. +> [!IMPORTANT] +> The mental model of Airflow 2.11 is bridge release for Airflow 3. Review Comment: ```suggestion > The mental model of Airflow 2.11 is a bridge release for Airflow 3. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update README_AIRFLOW3_DEV.md [airflow]
shahar1 opened a new pull request, #44304:
URL: https://github.com/apache/airflow/pull/44304
Applied some style and proofreading.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
