Re: [PR] Update i18n freeze instructions [airflow]
github-actions[bot] commented on PR #59136: URL: https://github.com/apache/airflow/pull/59136#issuecomment-3642386621 ### Backport failed to create: v3-1-test. View the failure log Run details Status Branch Result ❌ v3-1-test https://github.com/apache/airflow/commit/d8604c4bb2f8a424a47d3c0b623ceb98f54897ed";> You can attempt to backport this manually by running: ```bash cherry_picker d8604c4 v3-1-test ``` This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
bbovenzi merged PR #59136: URL: https://github.com/apache/airflow/pull/59136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
shahar1 commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2600055574 ## airflow-core/src/airflow/ui/public/i18n/README.md: ## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. +It should be announced when the median coverage across all translations is below the completeness threshold, or when needed (e.g., due to a critical UI feature that requires many new terms to be added). Review Comment: It's also mentioned in the definitions at the top, but I added it here anyway in parentheses :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
amoghrajesh commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2597097806 ## airflow-core/src/airflow/ui/public/i18n/README.md: ## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. +It should be announced when the median coverage across all translations is below the completeness threshold, or when needed (e.g., due to a critical UI feature that requires many new terms to be added). Review Comment: What's the "threshold" and how is it measured? ## airflow-core/src/airflow/ui/public/i18n/README.md: ## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. +It should be announced when the median coverage across all translations is below the completeness threshold, or when needed (e.g., due to a critical UI feature that requires many new terms to be added). Review Comment: I see below its through a script, better to mention that here ## airflow-core/src/airflow/ui/public/i18n/README.md: ## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +A few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. Review Comment: ```suggestion A few weeks before a minor or major release, a freeze time for accepting new translations MAY be announced in the dev list by the Release Manager. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
choo121600 commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2596008624 ## dev/breeze/src/airflow_breeze/commands/ui_commands.py: ## Review Comment: Understood 🚥, thanks! 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
choo121600 commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2596008624 ## dev/breeze/src/airflow_breeze/commands/ui_commands.py: ## Review Comment: Understood, thanks! 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
shahar1 commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2595994845 ## dev/breeze/src/airflow_breeze/commands/ui_commands.py: ## Review Comment: > I noticed something while looking at this logic. Right now, above 95% is marked as green, but we typically consider complete only when it’s at 100%. Would it make more sense to show green only when the coverage is exactly 100%? What do you think? The definition for completeness from the policy is actually above 90% :) I came up with this number so it would be high enough on one hand, but not too high to give some flexibility to all parties (for example, if translators of a specific language didn't catch recent changes on time). So you could thing of the range of 90%-100% as a traffic light, where 95%-100% is "safe" (green) , 90%-95% should ring a bell (yellow), and below 90% needs a wake up call (red). I hope that it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
choo121600 commented on PR #59136: URL: https://github.com/apache/airflow/pull/59136#issuecomment-3621565872 Aside from one question I have, everything looks good to me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
choo121600 commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2595908148 ## dev/breeze/src/airflow_breeze/commands/ui_commands.py: ## Review Comment: I noticed something while looking at this logic. Right now, above 95% is marked as green, but we typically consider complete only when it’s at 100%. Would it make more sense to show green only when the coverage is exactly 100%? What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Update i18n freeze instructions [airflow]
Copilot commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2595075103 ## airflow-core/src/airflow/ui/public/i18n/README.md: ## @@ -366,11 +366,11 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +Few weeks before a minor or major release, a freeze time for accepting new translations, might be announced in the dev list by the Release Manager. Review Comment: Grammar improvements needed: Add "A" at the beginning and remove the unnecessary comma after "translations". The sentence should read: "A few weeks before a minor or major release, a freeze time for accepting new translations might be announced..." ```suggestion A few weeks before a minor or major release, a freeze time for accepting new translations might be announced in the dev list by the Release Manager. ``` ## dev/README_RELEASE_AIRFLOW.md: ## @@ -86,20 +86,74 @@ The first step of a release is to work out what is being included. This differs - For a *patch* release, you will be selecting specific commits to cherry-pick and backport into the existing release branch. -## Validating completeness of i18n locale files and announcing i18n freeze time +## i18n workflow > [!NOTE] -> It is recommended to delegate all operations in this task to another committer. +> +> 1. The instructions in this section should be applied only for major/minor releases. +> 2. It is recommended to delegate all operations in this task to another committer. +> 3. Except for the dev list announcements, it is recommended to communicate them via the #i18n Slack channel as well. -Before cutting the release candidate (RC), you should announce a freeze time for i18n changes to allow translators to complete translations for the upcoming release without being overloaded by new terms, or other significant changes. -The freeze should last at least one week, and until the RC is cut. -It is recommended to announce the freeze at least two weeks before it starts. -To prepare for the announcement, generate an output of completeness for all locale files - follow the instructions in section 8.1 of the [internationalization (i18n) policy](../airflow-core/src/airflow/ui/public/i18n/README.md#81-checking-completeness-of-i18n-files) for doing so. -The reminder should be sent via [email protected] mailing list - you may accompany it with a GitHub issue for tracking purposes. +### Validating completeness of locale files -> [!NOTE] -> When applicable - you should mention, within the output, translations that have been incomplete in the past release, -> and warn that they might be removed if they are not completed by the release date. +Before cutting the release candidate (RC), you should verify the completeness of all merged locale files. +Generate a completeness output for all locale files – follow the instructions in section 8.1 of the [internationalization (i18n) policy](../airflow-core/src/airflow/ui/public/i18n/README.md#81-checking-completeness-of-i18n-files) to do so. +If the median completeness across all supported languages is below 90%, or upon other justifying circumstances (e.g., release of a critical UI feature), you should consider skipping the following instructions and applying an i18n translation freeze instead (see subsection below). +Otherwise, you should announce the completeness status to the [email protected] mailing list. + +Subject: + +```shell script +[ANNOUNCEMENT] i18n completeness check for Airflow ${VERSION} RC +``` + +Body (assuming delegation to another committer): + + +```shell script +cat <. + +After running the i18n completeness script, this is the coverage state of all merged locales as of : + + + +Code owners, translation owners, and engaged translators whose locales are currently below 90% coverage are kindly asked to complete their translations prior to the RC being cut. +This will help ensure that all languages included in the upcoming release remain complete and consistent. + +Contributors are also encouraged to plan their PRs accordingly and avoid introducing large sets of new English terms close to the release date, to prevent unexpected translation work for code owners. + +Important notes: +1. Locales that remain incomplete for two consecutive major or minor releases may be removed from the project, according to the i18n policy. +2. Any changes merged after the final release won't be included, and missing terms will fall back to English. +3. Code owners are responsible for ensuring that their assigned locales reach at least 90% coverage before the RC is cut. +4. Requests for assistance, coordination, or early heads-up on expected terminology changes may be shared in the #i18n Slack
Re: [PR] Update i18n freeze instructions [airflow]
Copilot commented on code in PR #59136: URL: https://github.com/apache/airflow/pull/59136#discussion_r2595049480 ## airflow-core/src/airflow/ui/public/i18n/README.md: ## @@ -366,8 +366,9 @@ breeze ui check-translation-completeness --verbose --all-files ## 11. Freeze time -Few weeks before a minor or major release, a freeze time for accepting new translations -MUST be announced in the dev list, to allow time for testing and verification of translations. +When the average coverage across all translations in below the completeness threshold, or when needed, the Release Manager might announce a freeze time for accepting new terms in the default language (English). +The freeze should help translators complete their translation work without being overloaded. +It will be announced in the dev list about two weeks before it starts, to allow time for preparing, and it should last until average completeness is back above the threshold or RC is cut for the release (whichever is earlier). Review Comment: Incomplete sentence: The sentence ends abruptly with "it should last until th." and appears to be cut off mid-word. This should be completed, likely "it should last until the average coverage reaches at least 90% again" or similar. ## dev/README_RELEASE_AIRFLOW.md: ## @@ -125,13 +179,15 @@ After running the i18n completeness script, this is the coverage state of all me To prevent overloading the translators and to ensure completeness of all translations by the release, a freeze upon the English locale will be applied starting , and until the RC is cut. Code owners, translation owners, and engaged translators are asked to complete the coverage of their assigned locales during this time. +Contributors are also encouraged to plan their PRs accordingly, to avoid modifying the English locale during the freeze time. Important notes: -1. Any changes merged after the final release won't not be included, and missing terms will fall back to English. -2. Any PR that modifies the English locale during the freeze time will fail CI checks. -3. Requests for exemptions should be communicated in the #i18n Slack channel, and approved by at least 1 PMC member - guidelines for approval are available in the i18n policy. -4. PRs approved for an exemption will be labeled with `allow translation change`, and then the relevant CI check will pass. Translators are encouraged to complete the translations for the exempted terms during the freeze time. -5. Merging PRs for adding new translations could be done during the freeze time - designated code owners should validate that by the end of the freeze time, the coverage of the suggested translation is complete. +1. Locales that remain incomplete for two consecutive major or minor releases may be removed from the project, according to the i18n policy. +2. Any changes merged after the final release won't not be included, and missing terms will fall back to English. Review Comment: Spelling error: "won't not" should be "won't" (double negative). ```suggestion 2. Any changes merged after the final release won't be included, and missing terms will fall back to English. ``` ## dev/README_RELEASE_AIRFLOW.md: ## @@ -86,20 +86,74 @@ The first step of a release is to work out what is being included. This differs - For a *patch* release, you will be selecting specific commits to cherry-pick and backport into the existing release branch. -## Validating completeness of i18n locale files and announcing i18n freeze time +## i18n workflow > [!NOTE] -> It is recommended to delegate all operations in this task to another committer. +> +> 1. The instructions in this section should be applied only for major/minor releases. +> 2. It is recommended to delegate all operations in this task to another committer. +> 3. Except for the dev list announcements, it is recommended to communicate them via the #i18n Slack channel as well. -Before cutting the release candidate (RC), you should announce a freeze time for i18n changes to allow translators to complete translations for the upcoming release without being overloaded by new terms, or other significant changes. -The freeze should last at least one week, and until the RC is cut. -It is recommended to announce the freeze at least two weeks before it starts. -To prepare for the announcement, generate an output of completeness for all locale files - follow the instructions in section 8.1 of the [internationalization (i18n) policy](../airflow-core/src/airflow/ui/public/i18n/README.md#81-checking-completeness-of-i18n-files) for doing so. -The reminder should be sent via [email protected] mailing list - you may accompany it with a GitHub issue for tracking purposes. +### Validating completeness of locale files -> [!NOTE] -> When applicable - you should mention, within the output, translations that have been incomplete in the past release,
[PR] Update i18n freeze instructions [airflow]
shahar1 opened a new pull request, #59136:
URL: https://github.com/apache/airflow/pull/59136
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
