Re: [I] AIP-84 Rework Asset API URLs to solve conflicting routes [airflow]

2024-12-11 Thread via GitHub


pierrejeambrun commented on issue #44609:
URL: https://github.com/apache/airflow/issues/44609#issuecomment-2536677327

   > @pierrejeambrun , Could you please check if `get_asset_events` and ` 
create_asset_event` have the same path `/assets/events`, and if they conflict?
   
   The method is not the same ‘GET’ vs ‘POST’. That shouldn’t be a problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] AIP-84 Rework Asset API URLs to solve conflicting routes [airflow]

2024-12-11 Thread via GitHub


pierrejeambrun closed issue #44609: AIP-84 Rework Asset API URLs to solve 
conflicting routes
URL: https://github.com/apache/airflow/issues/44609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] AIP-84 Rework Asset API URLs to solve conflicting routes [airflow]

2024-12-11 Thread via GitHub


pierrejeambrun commented on issue #44609:
URL: https://github.com/apache/airflow/issues/44609#issuecomment-2535907934

   Thanks @Prab-27, indeed this is solved by 
https://github.com/apache/airflow/pull/44801. 
   
   Closing.
   
   Adopted solution was:
   > First approach to solve this would most probably be to swap the use of uri 
as an identifier for the backend to instead use the id (autoincremented int) 
therefore resolving the possible conflicts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] AIP-84 Rework Asset API URLs to solve conflicting routes [airflow]

2024-12-11 Thread via GitHub


Prab-27 commented on issue #44609:
URL: https://github.com/apache/airflow/issues/44609#issuecomment-2535887040

   @pierrejeambrun , There is one PR merged #44801 that changed uri: str to id: 
int.
   
   Would you please tell me if I still need to de-nest the endpoints, or if 
this has already been resolved


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] AIP-84 Rework Asset API URLs to solve conflicting routes [airflow]

2024-12-03 Thread via GitHub


pierrejeambrun commented on issue #44609:
URL: https://github.com/apache/airflow/issues/44609#issuecomment-2514857696

   Hell @Prab-27,
   
   You are assigned :) Feel free to work on that. Files for the `Asset` API are 
located in `airflow/api_fastapi/core_api/routes/public/assets.py`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] AIP-84 Rework Asset API URLs to solve conflicting routes [airflow]

2024-12-03 Thread via GitHub


Prab-27 commented on issue #44609:
URL: https://github.com/apache/airflow/issues/44609#issuecomment-2514799593

   Hello @pierrejeambrun,I am a newbie and I'd like to work on this issue 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org