Re: [I] Add support for Papermill using https [airflow]
potiuk commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-4106162990 > I wonder should GatewayKernelManager be used directly, or do we need a custom WebSocket client? And SSL certificate validation? And does the operator need a kernel_id param for the gateway path, or always start a new kernel? since Kernel ID vs kernel name which JupyterHub may require a pre-existing kernel ID I guess you should create PR with your proposal, get it green and then it will be reviewed. It can always be changed - part of the task is also to choose the approach that you think is best. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
ThyTran1402 commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-4103607859 I wonder should GatewayKernelManager be used directly, or do we need a custom WebSocket client? And SSL certificate validation? And does the operator need a kernel_id param for the gateway path, or always start a new kernel? since Kernel ID vs kernel name which JupyterHub may require a pre-existing kernel ID -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
ThyTran1402 commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-4103598956 Hi @potiuk @andersonrl66 I'm currently working on this issue. I'm able to find the root cause is that #34840 added remote kernel support using raw ZMQ over TCP, but JupyterHub exposes kernels via https + websocket + bearer token, which is a fundamentally different protocol. The two connection models are incompatible. So, the fix is adding url, token, scheme to KernelConnection, and implementing an http/websocket-based kernel manager instead of extending AsyncKernelManager. Moreover, I also add a separate engine that passes gateway_url + token kwargs rather than port/key kwargs and register the new engine. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
potiuk commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-3986448150 @zk2k2 We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes). This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready. We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
zk2k2 commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-3095902460 @Lee-W thank you! I will try and submit a PR ASAP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
Lee-W commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-3092304050 @zk2k2 Just assigned it to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
zk2k2 commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-3042325959 Hello can you please assign me this issue? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
potiuk commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-3037206915 Sure - made it a "good first issue" for someone to pick up. Feel free to attempt it yourself or help anyone who will - maybe - want to implement it, to explain more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Add support for Papermill using https [airflow]
boring-cyborg[bot] commented on issue #52893: URL: https://github.com/apache/airflow/issues/52893#issuecomment-3037139320 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
