Re: [I] Convert all example_dags inside providers to use TaskSDK dag imports [airflow]
Bowrna commented on issue #49648: URL: https://github.com/apache/airflow/issues/49648#issuecomment-3988768352 Sure @potiuk it makes sense. I have been following the discussion happening around the mailing list around this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Convert all example_dags inside providers to use TaskSDK dag imports [airflow]
potiuk commented on issue #49648: URL: https://github.com/apache/airflow/issues/49648#issuecomment-3986457332 @Bowrna We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes). This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready. We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Convert all example_dags inside providers to use TaskSDK dag imports [airflow]
gopidesupavan commented on issue #49648: URL: https://github.com/apache/airflow/issues/49648#issuecomment-2887166706 > [@gopidesupavan](https://github.com/gopidesupavan) Sorry I got to check this issue today. I am missing some context here. I see that the related dag issue linked here is related to "max_consecutive_failed_dag_runs" which is set as default to -1 in TaskSDK and is fixed now to 0( Same count as what was in serialized dagbag). How is this issue related to it? Could you give me more context on that part? Thank you. Yes @Bowrna this issue not directly related to that we have fixed, but its a side effect we have noticed, In the `round trip example test` we parse the DAG and compares the serialised fields. so at present there is inconsistency some examples uses old way importing DAG definition and some or new way. we would like all the DAG imports from task sdk. thats the ideal way and users should be using, so when users sees our example and found old imports they may confuse. :) . I will take a look your changes tomorrow. Thanks for taking this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Convert all example_dags inside providers to use TaskSDK dag imports [airflow]
gopidesupavan commented on issue #49648: URL: https://github.com/apache/airflow/issues/49648#issuecomment-2826482193 Yes please. thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Convert all example_dags inside providers to use TaskSDK dag imports [airflow]
Bowrna commented on issue #49648: URL: https://github.com/apache/airflow/issues/49648#issuecomment-2826435152 @gopidesupavan Could i pick up this task and start working on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
