Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168377468 Yeah. That's wise choixe :) - and it's short which is cool. I am not too worried about pronounciation - or associations with kindergarten. Also easy to use it in conversations - we can even continue use "pre-commits" as a shortcut for `pre-commit hooks` - fonettically "prekomits run by prek" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168308670 Thank you shaw, really appreciated it ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
notatallshaw commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168292340 Another FYI, if it's pronounced as one syllable (instead of the two "pre" "k") it is phonetically _similar_ to "prick" which has many meanings: https://www.merriam-webster.com/dictionary/prick. Again, no objection, just letting you know as you said English wasn't your first language. If the tool gets popular you will likely need to provide a pronunciation guide in the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
notatallshaw commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168247434 I'm not sure if that's you but FYI `prek` in the US will likely have the association with pre-K, short for pre-kindergarten: https://en.wikipedia.org/wiki/Pre-kindergarten I have no objection to that, but just wanted you to be aware. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168227314 I'm going to rename to `prek`, hope it's not a weird name :) Thanks everyone. https://github.com/j178/prefligit/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
ashb commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168218266 https://github.com/user-attachments/assets/8992b6d1-df39-497d-a162-1ab9ac48cfab"; /> "This project name is too similar to an existing project" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
ashb commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168212554 @notatallshaw Oh yeah, we got bitten by that on `apache-airflow-providers-edge` too oddly enough. The only way to see if it is available is to try and upload something, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
notatallshaw commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168205194 You should check if `pre-flight` is actually available by attempting to claim the name, PyPI might reject it with it's own internal typo squat filters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
ashb commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3168197358 @j178 It's a nice name (I like it personally, but I understand the complaints that it's a bit hard to type/easy to read as `preflight`). How about `pre-flight`? That seems to be available on both pypi and crates.io? I don't know if there are any other concerns/places you need to be unique on? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3167988849 Now I see that `prefligit` is really not a good name. But `preflight` is not an option--it's too common and already taken by a lot of places. I’m trying to come up with a different name. It’s tough, especially since English isn’t my first language. Do you have any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3167103643 > @j178 I have a question on the name prefligit -- would you consider renaming to preflight, or providing a convenience shim/symlink as part of the install? I think @ashb shim / symlink is not enough `uv tool install preflight` vs. `uv tool install prefligit` is really the issue, not the command name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3167095863 Hello @j78 -> see the discussion on https://lists.apache.org/thread/mb73g4rz56n5l0gjyzm9jzolnkkc6o5c When I raised awareness about changing pre-commit to prefligit, a LOT of people thought it's "preflight". Enough confusion that we started to worry about typosquatting. I think there is really high risk a lot of our contributors will install https://pypi.org/project/preflight/#history instead of prefligit. Have you thought maybe about changing name ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
ashb commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3167095384 @j178 I have a question on the name `prefligit` -- would you consider renaming to `preflight`, or providing a convenience shim/symlink as part of the install? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3164682526 > Yes! That's is exactly what prefligit monorepo is trying to solve! So - we can even leave it "as is" this is no change comparing to `pre-commit` and we should keep full compatibilty for some time as we wil be switching. BTW. I send an "early warning" airflow dev community https://lists.apache.org/thread/mb73g4rz56n5l0gjyzm9jzolnkkc6o5c - that we are going to switch - and I'd say if the autocomplete is merged with other fixes, we could attempt to make PR to switch it in our CI and remove the wrapper from breeze pretty completely. The only missing thing as I see now is `--only-my-changes` but this is really nice to have, not a blocker for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3164215461 > in the future when monorepo support is implemented we can just move this and other golang hooks to "go-sdk/.pre-commit.yaml` Yes! That's is exactly what prefligit monorepo is trying to solve! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3163607515 > > go-mod-tidy has language: system, it relies on the system installed go, so this is expected I think. > > Ok. So that fix is on our side. O. The only reason we have it as `system` was that we could not have working-directory set for the golang pre-commit. the `go mod tidy` must be run in the `go-sdk` directory in order to work and that is not possible with `golang` pre-commits. However I guess in case of `prefligit` this can be fixed - say `workdir` - and in the future when monorepo support is implemented we can just move this and other golang hooks to "go-sdk/.pre-commit.yaml` ? @j178 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3163566210 > or example flynt in our repo sems to produce some formatting differences: Works fine for me, trying to reproduce on clean machine. It also works for me now. Could be red-herring on my other linux machine or maybe there was a commit broken when I run it. https://github.com/user-attachments/assets/498a1c5c-78c7-4071-9806-d2fcaffe52a0"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3163555465 I've also added one more feature request that our breeze wrapper implements https://github.com/j178/prefligit/issues/384 - nice to have, but pretty helpful :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3163551551 > go-mod-tidy has language: system, it relies on the system installed go, so this is expected I think. Ok. So that fix is on our side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
choo121600 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3162641540 Really looking forward to this 👀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3162497490 > Run go mod tidy.Failed > - hook id: go-mod-tidy > - exit code: 127 > bash: line 1: go: command not found > Format go code. `go-mod-tidy` has `language: system`, it relies on the system installed go, so this is expected I think. > Also go-mockery complains about read-only filesystem: Fixed in https://github.com/j178/prefligit/pull/377 > for example flynt in our repo sems to produce some formatting differences: Works fine for me, trying to reproduce on clean machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3160392311 Does not seem we are too far though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3160388369 Also go-mockery complains about read-only filesystem: ``` Generate mocks for go...Failed - hook id: go-mockery - exit code: 1 2025-08-06T14:19:47.994337813Z INF Starting mockery config-file=/src/go-sdk/.mockery.yml version=v3.5.1 2025-08-06T14:19:48.406289893Z INF Parsing configured packages... version=v3.5.1 2025-08-06T14:19:54.453557356Z INF Done parsing configured packages. version=v3.5.1 2025-08-06T14:19:54.453740620Z INF adding interface to collection collection=pkg/api/mocks/ClientInterface.go interface=ClientInterface package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.453877407Z INF adding interface to collection collection=pkg/api/mocks/AssetEventsClient.go interface=AssetEventsClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.453999590Z INF adding interface to collection collection=pkg/api/mocks/AssetsClient.go interface=AssetsClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454118286Z INF adding interface to collection collection=pkg/api/mocks/ConnectionsClient.go interface=ConnectionsClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454225964Z INF adding interface to collection collection=pkg/api/mocks/DagRunsClient.go interface=DagRunsClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454330629Z INF adding interface to collection collection=pkg/api/mocks/TaskInstancesClient.go interface=TaskInstancesClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454471722Z INF adding interface to collection collection=pkg/api/mocks/TaskReschedulesClient.go interface=TaskReschedulesClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454609039Z INF adding interface to collection collection=pkg/api/mocks/VariablesClient.go interface=VariablesClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454737564Z INF adding interface to collection collection=pkg/api/mocks/XcomsClient.go interface=XcomsClient package-path=github.com/apache/airflow/go-sdk/pkg/api version=v3.5.1 2025-08-06T14:19:54.454854302Z INF adding interface to collection collection=worker/mocks/Task.go interface=Task package-path=github.com/apache/airflow/go-sdk/worker version=v3.5.1 2025-08-06T14:19:54.454993340Z INF adding interface to collection collection=worker/mocks/Registry.go interface=Registry package-path=github.com/apache/airflow/go-sdk/worker version=v3.5.1 2025-08-06T14:19:54.455122487Z INF adding interface to collection collection=worker/mocks/Worker.go interface=Worker package-path=github.com/apache/airflow/go-sdk/worker version=v3.5.1 2025-08-06T14:19:54.455277988Z INF Executing template file=pkg/api/mocks/TaskReschedulesClient.go version=v3.5.1 2025-08-06T14:19:54.456937873Z INF Writing template to file file=pkg/api/mocks/TaskReschedulesClient.go version=v3.5.1 2025-08-06T14:19:54.457019503Z FTL app failed error="open pkg/api/mocks/TaskReschedulesClient.go: read-only file system" version=v3.5.1 Run go mod tidy.Failed ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3160390576 And go mod tidy complains about no go found: ``` 2025-08-06T14:19:54.457019503Z FTL app failed error="open pkg/api/mocks/TaskReschedulesClient.go: read-only file system" version=v3.5.1 Run go mod tidy.Failed - hook id: go-mod-tidy - exit code: 127 bash: line 1: go: command not found Format go code. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3160383844 I think there are few differences - I would have to make a bit more detailed checks-but seems some of the precommits produce slightly different results - as if not all the "configuration" is made available to them: * for example flynt in our repor sems to produce sine formatting differences: https://github.com/user-attachments/assets/2466be24-003a-4c49-a0dd-f68efe35f7b9"; /> Then it's a bit of cascadig event - ruff is also failing later (after those flyt changes), also we seem to have different result from asset compilation step But I guess that's something - you could try on our repo yourself :) and see what's going on :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3160349014 > [@potiuk](https://github.com/potiuk) [@ashb](https://github.com/ashb) I think I've fixed the `/usr/bin/env: ‘node’: No such file or directory` issue in [j178/prefligit#371](https://github.com/j178/prefligit/pull/371), would you mind try running the prefligit master branch? If not, no worries—I’ll release a new version soon. Works. (at least passess the node steps :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3159870340 @potiuk @ashb I think I've fixed the `/usr/bin/env: ‘node’: No such file or directory` issue in https://github.com/j178/prefligit/pull/371, would you mind try running the prefligit master branch? If not, no worries—I’ll release a new version soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3159710113 Also: prefligit is installed with `uv tool`. Here is more info: ``` [jarek:~/code/airflow] main+ ± uv tool list -v --show-paths --show-version-specifiers --show-with --show-extras DEBUG uv 0.8.4 DEBUG Acquired lock for `/home/jarek/.local/share/uv/tools` DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/apache-airflow-breeze` apache-airflow-breeze v0.0.1 [required: file:///home/jarek/code/airflow/dev/breeze] (/home/jarek/.local/share/uv/tools/apache-airflow-breeze) - breeze (/home/jarek/.local/bin/breeze) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/cherry-picker` cherry-picker v2.5.0 (/home/jarek/.local/share/uv/tools/cherry-picker) - cherry_picker (/home/jarek/.local/bin/cherry_picker) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/flit` flit v3.12.0 (/home/jarek/.local/share/uv/tools/flit) - flit (/home/jarek/.local/bin/flit) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/hatch` hatch v1.14.1 (/home/jarek/.local/share/uv/tools/hatch) - hatch (/home/jarek/.local/bin/hatch) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/pre-commit` pre-commit v4.2.0 [with: pre-commit-uv] (/home/jarek/.local/share/uv/tools/pre-commit) - pre-commit (/home/jarek/.local/bin/pre-commit) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/prefligit` prefligit v0.0.20 (/home/jarek/.local/share/uv/tools/prefligit) - prefligit (/home/jarek/.local/bin/prefligit) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/ruff` ruff v0.12.4 (/home/jarek/.local/share/uv/tools/ruff) - ruff (/home/jarek/.local/bin/ruff) DEBUG Checking for Python environment at: `/home/jarek/.local/share/uv/tools/twine` twine v6.1.0 (/home/jarek/.local/share/uv/tools/twine) - twine (/home/jarek/.local/bin/twine) DEBUG Released lock at `/home/jarek/.local/share/uv/tools/.lock` [jarek:~/code/airflow] main+ ± prefligit --version prefligit 0.0.20 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3159688805 > Can you show the log with `prefligit clean && prefligit run compile-ui-assets --all-files -vvv`? ``` [jarek:~/code/airflow] main+ 3s ± prefligit run --all-files -vvv DEBUG prefligit: 0.0.20 TRACE Executing `/usr/bin/git rev-parse --show-toplevel` DEBUG Git root: /home/jarek/code/airflow DEBUG Loading project configuration path=/home/jarek/code/airflow/.pre-commit-config.yaml TRACE Checking lock resource="store" path=/home/jarek/.cache/prefligit/.lock DEBUG Acquired lock resource="store" DEBUG Hooks going to run: ["identity", "check-hooks-apply", "doctoc", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "insert-license", "check-min-python-version", "update-black-version", "update-installers-and-pre-commit", "update-chart-dependencies", "check-taskinstance-tis-attrs", "check-deferrable-default", "blacken-docs", "check-merge-conflict", "debug-statements", "check-builtin-literals", "detect-private-key", "end-of-file-fixer", "mixed-line-ending", "check-executables-have-shebangs", "check-xml", "trailing-whitespace", "fix-encoding-pragma", "pretty-format-json", "rst-backticks", "python-no-log-warn", "yamllint", "flynt", "codespell", "zizmor", "update-providers-dependencies", "check-shared-distributions-structure", "check-shared-distributions-usage", "validate-operators-init", "update-providers-build-files", "check-airflow- v-imports-in-tests", "ruff", "ruff-format", "replace-bad-characters", "lint-dockerfile", "check-airflow-k8s-not-used", "check-common-compat-used-for-openlineage", "check-airflow-providers-bug-report-template", "check-cncf-k8s-only-for-executors", "update-local-yml-file", "check-sql-dependency-common-data-structure", "check-extra-packages-references", "check-extras-order", "generate-airflow-diagrams", "generate-volumes-for-sources", "prevent-deprecated-sqlalchemy-usage", "update-supported-versions", "check-revision-heads-map", "update-version", "check-pydevd-left-in-code", "check-pytest-mark-db-test-in-providers", "check-links-to-example-dags-do-not-use-hardcoded-versions", "check-safe-filter-usage-in-html", "check-no-providers-in-core-examples", "check-no-airflow-deprecation-in-providers", "check-urlparse-usage-in-code", "check-only-new-session-with-provide-session", "check-for-inclusive-language", "check-base-operator-partial-arguments", "check-init-decorator-arguments", "check-tem plate-context-variable-in-sync", "check-base-operator-usage", "check-base-operator-usage", "check-base-operator-usage", "check-get-lineage-collector-providers", "check-decorated-operator-implements-custom-name", "check-core-deprecation-classes", "check-provide-create-sessions-imports", "check-incorrect-use-of-LoggingMixin", "check-start-date-not-used-in-defaults", "check-apache-license-rat", "check-aiobotocore-optional", "check-boring-cyborg-configuration", "update-in-the-wild-to-be-sorted", "update-installed-providers-to-be-sorted", "update-spelling-wordlist-to-be-sorted", "lint-helm-chart", "validate-chart-annotations", "kubeconform", "shellcheck", "compile-ui-assets", "compile-fab-assets", "compile-ui-assets-dev", "check-providers-subpackages-init-file-exist", "check-pre-commit-information-consistent", "check-integrations-list-consistent", "update-breeze-readme-config-hash", "update-pyproject-toml", "update-reproducible-source-date-epoch", "check-breeze-top-dependencies-limited", "check-tests-in-the-right-folders", "check-system-tests-present", "generate-pypi-readme", "lint-markdown", "lint-json-schema", "lint-json-schema", "lint-json-schema", "lint-json-schema", "update-vendored-in-k8s-json-schema", "lint-json-schema", "lint-json-schema", "check-persist-credentials-disabled-in-github-workflows", "check-docstring-param-types", "check-zip-file-is-not-committed", "check-code-deprecations", "lint-chart-schema", "update-inlined-dockerfile-scripts", "check-changelog-has-no-duplicates", "check-changelog-format", "check-newsfragments-are-valid", "check-significant-newsfragments-are-valid", "update-breeze-cmd-output", "check-example-dags-urls", "check-system-tests-tocs", "check-lazy-logging", "create-missing-init-py-files-tests", "check-tests-unittest-testcase", "check-provider-docs-valid", "bandit", "pylint", "check-fab-migrations", "go-mockery", "go-mod-tidy", "gofmt", "gci", "ts-compile-lint-ui", "ts-compile-lint-simple-auth-manager-ui", "mypy-dev", "mypy-dev", "mypy-airflow-core", "mypy-airflow-core", "mypy-providers", "mypy-providers", "mypy-task-sdk", "mypy-task-sdk", "mypy-devel-common", "mypy-devel-common", "mypy-airflow-ctl", "mypy-airflow-ctl", "generate-openapi-spec", "generate-openapi-spec-fab", "check-i18n-json", "check-provider-yaml-valid", "c
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3159695101 And it does not fix itself on re-running :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
ashb commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3159022541 I had the same issue as Jarek, but on re-running it seemed to fix itself, so I didn't dig any further. @j178 I did just notice this issue https://github.com/j178/prefligit/issues/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3158742536 Can you show the log with `prefligit run --all-files -vvv`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3158731025 `prefligit` does install a node version that's compitible with the hook, we have a test for this. Let me see what's going wrong here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3158375756 Also this: ``` node --version v12.22.9 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995:
URL: https://github.com/apache/airflow/issues/44995#issuecomment-3158370820
I tried it with Airflow current .pre-commit config and we still have problem
with `node` pre-commits
When I had no node installed at all on my Linux on system level I got:
```
[jarek:~/code/airflow] main+ ± prefligit run --all-files
error: Failed to install hook `compile-ui-assets`
caused by: command `npm install` exited with an error:
[status]
exit status: 127
[stderr]
/usr/bin/env: ‘node’: No such file or directory
```
I installed npm using regular apt (mint 21.3 cinnamon):
```
sudo apt install npm
```
Then I get this:
```
[jarek:~/code/airflow] main+ ± prefligit run --all-files
error: Failed to install hook `lint-markdown`
caused by: command `npm install` exited with an error:
[status]
exit status: 1
[stderr]
internal/modules/cjs/loader.js:818
throw err;
^
Error: Cannot find module 'node:path'
Require stack:
-
/home/jarek/.cache/prefligit/tools/node/22.18.0-Jod/lib/node_modules/npm/lib/cli.js
-
/home/jarek/.cache/prefligit/tools/node/22.18.0-Jod/lib/node_modules/npm/bin/npm-cli.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
at Function.Module._load (internal/modules/cjs/loader.js:667:27)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:85:18)
at Object.
(/home/jarek/.cache/prefligit/tools/node/22.18.0-Jod/lib/node_modules/npm/lib/cli.js:10:18)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/home/jarek/.cache/prefligit/tools/node/22.18.0-Jod/lib/node_modules/npm/lib/cli.js',
'/home/jarek/.cache/prefligit/tools/node/22.18.0-Jod/lib/node_modules/npm/bin/npm-cli.js'
]
}
```
I think `prefligit` should install complete node environment even if you do
not have one installed (this is what pre-commit does) - we actually use that
feature in our `breeze` environment, we are using the fact that `pre-commit`
will install the specified node version from scratch under-the-hood when it is
used in .pre-commit-config.yml. We have a number of people who do not do UI
development, don't have node installed and we do not want them to bother about
it when we need to compile assets when locally installing airlfow for
development. The nice thing about node setup done by `pre-commit` is that it
**just works**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3155410707 Cooo. I am also looking forward to TODO! monorepo support. That would help us to modularise our pre-commits way, way better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3155405741 👀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3154921964 @ashb Hi! Just wanted to let you know that with the prefligit [0.0.20](https://github.com/j178/prefligit/releases/tag/v0.0.20) release, all languages that Airflow uses are now supported. I think it’s a good time for you to give it a try! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
ashb commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3151794072 @j178 Love it! I'm happy to drive this locally at any point you tell me you think it's good enough for local testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
j178 commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-3150659970 Hey, I’m the author of prefligit 👋🏻, just wanted to stop by and share the latest updates: prefligit now fully supports Python and Node, and we're adding Go support coming soon! So, it won’t be long before you can run all your airflow hooks through prefligit. And here are some cool benchmark numbers: for a cold installation of airflow hooks, prefligit is about 10x faster than pre-commit and takes up only a third of the disk space. That said, prefligit isn’t production-ready yet. I’d love for airflow to be the first big adaptor and would really appreciate any help with testing! Let me know if you’re interested! https://github.com/user-attachments/assets/054ff758-fb53-4beb-8bf8-8ac1a19db527"; /> https://github.com/user-attachments/assets/c5622834-bf49-44ba-9ed2-628728817e98"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995: URL: https://github.com/apache/airflow/issues/44995#issuecomment-2549437680 > Shell completion! > > https://github.com/j178/prefligit/blob/921f86411cc2de04dbf94c696d572665bfca467f/src/main.rs#L235 That's what I was sincerely hoping for. This is main reason why we have `breeze static-checks`, another one are some predefined flags like `--last-comit` and `--only-my-changes` which I hope we might be able to contribute to prefligit once we get it working :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] Replace pre-commit with prefligit [airflow]
potiuk commented on issue #44995:
URL: https://github.com/apache/airflow/issues/44995#issuecomment-2548801695
Current status - it fails wit:
```
[jarek:~/code/airflow] main+ 101 ± RUST_BACKTRACE=1 prefligit run
⠙ Initializing hooks...
thread 'main'
panicked at src/languages/mod.rs:47:18:
not yet implemented
stack backtrace:
0: rust_begin_unwind
1: core::panicking::panic_fmt
2: core::panicking::panic
3: prefligit::hook::HookBuilder::combine
4: prefligit::hook::Project::init_hooks::{{closure}}
5: prefligit::cli::run::run::run::{{closure}}
6: prefligit::run::{{closure}}
7: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
8: tokio::runtime::runtime::Runtime::block_on
9: prefligit::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose
backtrace.
[jarek:~/code/airflow] main+ 101 ±
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
