Re: [PR] #46316 Issue: Update start.rst [airflow]
boring-cyborg[bot] commented on PR #46335: URL: https://github.com/apache/airflow/pull/46335#issuecomment-2637906659 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
potiuk merged PR #46335: URL: https://github.com/apache/airflow/pull/46335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
potiuk commented on PR #46335: URL: https://github.com/apache/airflow/pull/46335#issuecomment-2637307333 Soem static checks are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
SaumilPatel03 commented on code in PR #46335: URL: https://github.com/apache/airflow/pull/46335#discussion_r1939297177 ## docs/apache-airflow/start.rst: ## @@ -24,7 +24,7 @@ This quick start guide will help you bootstrap an Airflow standalone instance on .. note:: - Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11 and 3.12. + Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11, and 3.12. Review Comment: Thank you for the clarification, @eladkal. Just to confirm, should I leave the Python version specification as it is (listing 3.9, 3.10, 3.11, and 3.12), or are there any other changes you would recommend for my commit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
eladkal commented on code in PR #46335: URL: https://github.com/apache/airflow/pull/46335#discussion_r1938634579 ## docs/apache-airflow/start.rst: ## @@ -24,7 +24,7 @@ This quick start guide will help you bootstrap an Airflow standalone instance on .. note:: - Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11 and 3.12. + Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11, and 3.12. Review Comment: No, because we don't support 3.13 officially. New version support comes late to Airflow because we have many upstream depndencies and it takes them time to add new version support. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
SaumilPatel03 commented on PR #46335: URL: https://github.com/apache/airflow/pull/46335#issuecomment-2629229547 @RNHTTR @potiuk Can you please review my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
SaumilPatel03 closed pull request #46335: #46316 Issue: Update start.rst URL: https://github.com/apache/airflow/pull/46335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
SaumilPatel03 commented on code in PR #46335: URL: https://github.com/apache/airflow/pull/46335#discussion_r1937798520 ## docs/apache-airflow/start.rst: ## @@ -24,7 +24,7 @@ This quick start guide will help you bootstrap an Airflow standalone instance on .. note:: - Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11 and 3.12. + Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11, and 3.12. Review Comment: Should I change it to "Starting with Airflow 2.7.0, Airflow supports Python >= 3.9" ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
RNHTTR commented on code in PR #46335: URL: https://github.com/apache/airflow/pull/46335#discussion_r1937770447 ## docs/apache-airflow/start.rst: ## @@ -44,14 +44,33 @@ This quick start guide will help you bootstrap an Airflow standalone instance on The installation of Airflow is straightforward if you follow the instructions below. Airflow uses constraint files to enable reproducible installation, so using ``pip`` and constraint files is recommended. -1. Set Airflow Home (optional): +1. **(Recommended) Create and Activate a Virtual Environment**: Review Comment: Can you maybe add a link to the externally-managed-environment error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
RNHTTR commented on code in PR #46335: URL: https://github.com/apache/airflow/pull/46335#discussion_r1937769681 ## docs/apache-airflow/start.rst: ## @@ -24,7 +24,7 @@ This quick start guide will help you bootstrap an Airflow standalone instance on .. note:: - Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11 and 3.12. + Successful installation requires a Python 3 environment. Starting with Airflow 2.7.0, Airflow supports Python 3.9, 3.10, 3.11, and 3.12. Review Comment: Should this just say "Starting with Airflow 2.7.0, Airflow supports Python >= 3.9"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] #46316 Issue: Update start.rst [airflow]
boring-cyborg[bot] commented on PR #46335: URL: https://github.com/apache/airflow/pull/46335#issuecomment-2628041854 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
