Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
jedcunningham commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2741138418 Yours is a bit more comprehensive than mine (#47958). I can do the password extra removal separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2746165044 Deleted hatch_build by mistake. Ooops :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
vincbeck commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2740658231 Tests are failing because of `JSONProvider`. But it does not seem to be used, so I guess we can just remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2741922608 Better to re-do it in the new form after https://github.com/apache/airflow/pull/47798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2748372820 Thanks for the assist @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb merged PR #48007: URL: https://github.com/apache/airflow/pull/48007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2748003700 Ah, I didn't resolve conflicts correctly. Lets try this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2747933614 This is an odd one: ``` E sqlalchemy.exc.ArgumentError: Type annotation for "TaskInstance.dag_model" can't be correctly interpreted for Annotated Declarative Table form. ORM annotations should normally make use of the ``Mapped[]`` generic type, or other ORM-compatible generic type, as a container for the actual type, which indicates the intent that the attribute is mapped. Class variables that are not intended to be mapped by the ORM should use ClassVar[]. To allow Annotated Declarative to disregard legacy annotations which don't use Mapped[] to pass, set "__allow_unmapped__ = True" on the class or a superclass this class. (Background on this error at: https://sqlalche.me/e/20/zlpr) === short test summary info ERROR kubernetes_tests/test_kubernetes_pod_operator.py - sqlalchemy.exc.ArgumentError: Type annotation for "TaskInstance.dag_model" can't be correctly interpreted for Annotated Declarative Table form. ORM annotations should normally make use of the ``Mapped[]`` generic type, or other ORM-compatible generic type, as a container for the actual type, which indicates the intent that the attribute is mapped. Class variables that are not intended to be mapped by the ORM should use ClassVar[]. To allow Annotated Declarative to disregard legacy annotations which don't use Mapped[] to pass, set "__allow_unmapped__ = True" on the class or a superclass this class. (Background on this error at: https://sqlalche.me/e/20/zlpr) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2747899603 Looking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2747662518 Possibly https://github.com/fastapi/fastapi/pull/12747 (0.115.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2747650183 Most likely: ```diff - fastapi==0.115.12 + fastapi==0.112.4 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2747637686 seems like fast_api/svcs has another implicit flask dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2747640683 > seems like fast_api/svcs has another implicit flask dependency but likely it's because it is there in an old version of it - as only "lowest dependencies" are impacted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2746255407 Fix here: https://github.com/apache/airflow/pull/48113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2746249508 > __ ERROR collecting airflow-core/tests/unit/always/test_providers_manager.py ___ Looks tests only. Possibly we shoud move the tests that use it to FAB (they are really testing "fab provider" variant of the providers_manager) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2746210613 Hmmm, somewhere we are still/yet again missing the dep on werkzeug: ``` __ ERROR collecting airflow-core/tests/unit/always/test_providers_manager.py ___ airflow-core/tests/unit/always/test_providers_manager.py:28: in from flask_babel import lazy_gettext /usr/local/lib/python3.10/site-packages/flask_babel/__init__.py:15: in from flask import current_app, request /usr/local/lib/python3.10/site-packages/flask/__init__.py:4: in from . import json as json /usr/local/lib/python3.10/site-packages/flask/json/__init__.py:8: in from ..globals import current_app /usr/local/lib/python3.10/site-packages/flask/globals.py:56: in app_ctx: "AppContext" = LocalProxy( # type: ignore[assignment] E TypeError: LocalProxy.__init__() got an unexpected keyword argument 'unbound_message' ``` I've run out of spare time this weekend, I'll take a look on Monday -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2746168224 > Deleted hatch_build by mistake. Ooops :) FYI With getting rid of `pip` I am eyeying hatch_build.py removal anyway ;) (for the meta package at least - custom build hooks for asset compilation and git hook will remain in `airflow-core` - but neither with `root` pyproject.toml nor in `apache-airflow` we will have dynamic dependencies, I believe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on code in PR #48007: URL: https://github.com/apache/airflow/pull/48007#discussion_r2009084653 ## hatch_build.py: ## @@ -206,15 +202,6 @@ # 0.115.10 fastapi was a bad release that broke our API's and static checks. # Related fastapi issue here: https://github.com/fastapi/fastapi/discussions/13431 "fastapi[standard]>=0.112.4,!=0.115.10", -"flask-caching>=2.0.0", -# Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface constructor as well as -# all parameters now are mandatory which make AirflowDatabaseSessionInterface incompatible with this version. -"flask-session>=0.4.0,<0.6", -"flask-wtf>=1.1.0", Review Comment: Ace. Rebased this now, lets see if it's good now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2745214333 Should be rebased now after airflow-core move as the dependncies moved to "airflow-core/pyproject.toml" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on code in PR #48007: URL: https://github.com/apache/airflow/pull/48007#discussion_r2008757930 ## hatch_build.py: ## @@ -206,15 +202,6 @@ # 0.115.10 fastapi was a bad release that broke our API's and static checks. # Related fastapi issue here: https://github.com/fastapi/fastapi/discussions/13431 "fastapi[standard]>=0.112.4,!=0.115.10", -"flask-caching>=2.0.0", -# Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface constructor as well as -# all parameters now are mandatory which make AirflowDatabaseSessionInterface incompatible with this version. -"flask-session>=0.4.0,<0.6", -"flask-wtf>=1.1.0", Review Comment: We could. Provider's manager currently handles missing flask imports gently - the only thing needed is to improve the `try/except` pattern there to handle it also for wtforms import. I added a fix for that https://github.com/apache/airflow/pull/48094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
potiuk commented on code in PR #48007:
URL: https://github.com/apache/airflow/pull/48007#discussion_r2008748894
##
airflow/utils/json.py:
##
@@ -18,70 +18,9 @@
from __future__ import annotations
import json
-from datetime import date, datetime
-from decimal import Decimal
from typing import Any
-from flask.json.provider import JSONProvider
-
-from airflow.serialization.serde import CLASSNAME, DATA, SCHEMA_ID,
deserialize, serialize
-from airflow.utils.timezone import convert_to_utc, is_naive
-
-
-class AirflowJsonProvider(JSONProvider):
-"""JSON Provider for Flask app to use WebEncoder."""
-
-ensure_ascii: bool = True
-sort_keys: bool = True
-
-def dumps(self, obj, **kwargs):
-kwargs.setdefault("ensure_ascii", self.ensure_ascii)
-kwargs.setdefault("sort_keys", self.sort_keys)
-return json.dumps(obj, **kwargs, cls=WebEncoder)
-
-def loads(self, s: str | bytes, **kwargs):
-return json.loads(s, **kwargs)
-
-
-class WebEncoder(json.JSONEncoder):
Review Comment:
Nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on code in PR #48007: URL: https://github.com/apache/airflow/pull/48007#discussion_r2005660413 ## hatch_build.py: ## @@ -206,15 +202,6 @@ # 0.115.10 fastapi was a bad release that broke our API's and static checks. # Related fastapi issue here: https://github.com/fastapi/fastapi/discussions/13431 "fastapi[standard]>=0.112.4,!=0.115.10", -"flask-caching>=2.0.0", -# Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface constructor as well as -# all parameters now are mandatory which make AirflowDatabaseSessionInterface incompatible with this version. -"flask-session>=0.4.0,<0.6", -"flask-wtf>=1.1.0", Review Comment: Flask-wtf I'm not 100% sure we can remove from core yet due to possible use in providers manager. Lets see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
jedcunningham commented on code in PR #48007: URL: https://github.com/apache/airflow/pull/48007#discussion_r2006102739 ## providers/common/compat/tests/unit/common/compat/test_check.py: ## Review Comment: This was fixed in main. It might be worth undoing these changes so this is consistent with the other tests here. ## hatch_build.py: ## @@ -206,15 +202,6 @@ # 0.115.10 fastapi was a bad release that broke our API's and static checks. # Related fastapi issue here: https://github.com/fastapi/fastapi/discussions/13431 "fastapi[standard]>=0.112.4,!=0.115.10", -"flask-caching>=2.0.0", -# Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface constructor as well as -# all parameters now are mandatory which make AirflowDatabaseSessionInterface incompatible with this version. -"flask-session>=0.4.0,<0.6", -"flask-wtf>=1.1.0", Review Comment: I don't think we can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
vincbeck commented on PR #48007: URL: https://github.com/apache/airflow/pull/48007#issuecomment-2740528371 Love to see all these deps moving away from airflow-core! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
vincbeck commented on code in PR #48007:
URL: https://github.com/apache/airflow/pull/48007#discussion_r2005862794
##
airflow/utils/json.py:
##
@@ -18,70 +18,9 @@
from __future__ import annotations
import json
-from datetime import date, datetime
-from decimal import Decimal
from typing import Any
-from flask.json.provider import JSONProvider
-
-from airflow.serialization.serde import CLASSNAME, DATA, SCHEMA_ID,
deserialize, serialize
-from airflow.utils.timezone import convert_to_utc, is_naive
-
-
-class AirflowJsonProvider(JSONProvider):
-"""JSON Provider for Flask app to use WebEncoder."""
-
-ensure_ascii: bool = True
-sort_keys: bool = True
-
-def dumps(self, obj, **kwargs):
-kwargs.setdefault("ensure_ascii", self.ensure_ascii)
-kwargs.setdefault("sort_keys", self.sort_keys)
-return json.dumps(obj, **kwargs, cls=WebEncoder)
-
-def loads(self, s: str | bytes, **kwargs):
-return json.loads(s, **kwargs)
-
-
-class WebEncoder(json.JSONEncoder):
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb commented on code in PR #48007:
URL: https://github.com/apache/airflow/pull/48007#discussion_r2005830464
##
airflow/utils/json.py:
##
@@ -18,70 +18,9 @@
from __future__ import annotations
import json
-from datetime import date, datetime
-from decimal import Decimal
from typing import Any
-from flask.json.provider import JSONProvider
-
-from airflow.serialization.serde import CLASSNAME, DATA, SCHEMA_ID,
deserialize, serialize
-from airflow.utils.timezone import convert_to_utc, is_naive
-
-
-class AirflowJsonProvider(JSONProvider):
-"""JSON Provider for Flask app to use WebEncoder."""
-
-ensure_ascii: bool = True
-sort_keys: bool = True
-
-def dumps(self, obj, **kwargs):
-kwargs.setdefault("ensure_ascii", self.ensure_ascii)
-kwargs.setdefault("sort_keys", self.sort_keys)
-return json.dumps(obj, **kwargs, cls=WebEncoder)
-
-def loads(self, s: str | bytes, **kwargs):
-return json.loads(s, **kwargs)
-
-
-class WebEncoder(json.JSONEncoder):
Review Comment:
The only usage of this left over was to make some logs more consuablable in
2 AWS operators -- so I've removed this and fixed those operators to just use
`repr` as the fallback JSON logging behaviour. It won't be the same but should
be "good enough"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] (Re)move old dependencies from the old FAB UI [airflow]
ashb closed pull request #48007: (Re)move old dependencies from the old FAB UI URL: https://github.com/apache/airflow/pull/48007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
