Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008967410 ## dev/breeze/doc/09_release_management_tasks.rst: ## @@ -689,3 +689,27 @@ default is to build ``both`` type of packages ``sdist`` and ``wheel``. :target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/doc/images/output_release-management_prepare-task-sdk-distributions.svg :width: 100% :alt: Breeze release-management prepare-task-sdk-distributions + + +Preparing airflow ctl packages Review Comment: Updated all packages to distributions in the document -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2745905740 I tried to merge distributions outside core tests in workflows so that the unique number can be persisted and if we have further tests needed for those new distributions, we can add them there without increasing the unique # of workflows. These are just conditional steps in the same workflow. I hope it will be green :crossed_fingers: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008967468 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -154,7 +154,7 @@ def docker_compose_tests( sys.exit(return_code) -TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|.*=.*" +TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|airflow-ctl/tests/.*|.*=.*" Review Comment: Already merged #48100 :tada: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2745369307 > Nice! Looks good already ! Thanks for the swift review Jarek! I will address them while fixing the workflow limitation. I will be away from pc for a while, I will come back and make the changes later today :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008814982 ## dev/breeze/doc/09_release_management_tasks.rst: ## @@ -689,3 +689,27 @@ default is to build ``both`` type of packages ``sdist`` and ``wheel``. :target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/doc/images/output_release-management_prepare-task-sdk-distributions.svg :width: 100% :alt: Breeze release-management prepare-task-sdk-distributions + + +Preparing airflow ctl packages Review Comment: Nice one :D Yes, I will update all of them :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008815449 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -154,7 +154,7 @@ def docker_compose_tests( sys.exit(return_code) -TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|.*=.*" +TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|airflow-ctl/tests/.*|.*=.*" Review Comment: My eyes still getting used to :) I see now what you will change :) I can also include it in this one for sure feel free to fix it separately :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
potiuk commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008811097 ## dev/breeze/src/airflow_breeze/commands/testing_commands.py: ## @@ -154,7 +154,7 @@ def docker_compose_tests( sys.exit(return_code) -TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|.*=.*" +TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|airflow-ctl/tests/.*|.*=.*" Review Comment: ```suggestion TEST_PROGRESS_REGEXP = r"tests/.*|providers/.*/tests/.*|task-sdk/tests/.*|airflow-ctl/tests/.*|.*=.*" ``` Ach .. I noticed one missed change in my move - here and below. I will fix it separately :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
potiuk commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008810826 ## dev/breeze/doc/09_release_management_tasks.rst: ## @@ -689,3 +689,27 @@ default is to build ``both`` type of packages ``sdist`` and ``wheel``. :target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/doc/images/output_release-management_prepare-task-sdk-distributions.svg :width: 100% :alt: Breeze release-management prepare-task-sdk-distributions + + +Preparing airflow ctl packages Review Comment: And below (likely there are a few remnants in other places in the docs as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [WIP] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
potiuk commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2008810741 ## dev/breeze/doc/09_release_management_tasks.rst: ## @@ -689,3 +689,27 @@ default is to build ``both`` type of packages ``sdist`` and ``wheel``. :target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/doc/images/output_release-management_prepare-task-sdk-distributions.svg :width: 100% :alt: Breeze release-management prepare-task-sdk-distributions + + +Preparing airflow ctl packages Review Comment: ```suggestion Preparing airflow ctl distributions ``` :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
