Re: [PR] 📧 Add email decorator [airflow]
github-actions[bot] closed pull request #41076: 📧 Add email decorator URL: https://github.com/apache/airflow/pull/41076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
github-actions[bot] commented on PR #41076: URL: https://github.com/apache/airflow/pull/41076#issuecomment-2506874505 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
potiuk commented on PR #41076: URL: https://github.com/apache/airflow/pull/41076#issuecomment-2408722114 You have now conflicts and you need to rebase it first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
bdsoha commented on PR #41076: URL: https://github.com/apache/airflow/pull/41076#issuecomment-2402329486 @eladkal Hey, any chance you can review this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
uranusjr commented on PR #41076: URL: https://github.com/apache/airflow/pull/41076#issuecomment-2287938368 Can you add an example DAG for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
bdsoha commented on PR #41076: URL: https://github.com/apache/airflow/pull/41076#issuecomment-2262957522 @eladkal Mind having a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
bdsoha commented on code in PR #41076: URL: https://github.com/apache/airflow/pull/41076#discussion_r1694233023 ## airflow/decorators/email.py: ## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import warnings +from typing import Any, Callable, Collection, Mapping, Sequence + +from airflow.decorators.base import DecoratedOperator, TaskDecorator, task_decorator_factory +from airflow.operators.email import EmailOperator +from airflow.utils.context import Context, context_merge +from airflow.utils.operator_helpers import determine_kwargs +from airflow.utils.types import NOTSET + + +class _EmailDecoratedOperator(DecoratedOperator, EmailOperator): Review Comment: Just made the move! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
eladkal commented on code in PR #41076: URL: https://github.com/apache/airflow/pull/41076#discussion_r1694229555 ## airflow/decorators/email.py: ## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import warnings +from typing import Any, Callable, Collection, Mapping, Sequence + +from airflow.decorators.base import DecoratedOperator, TaskDecorator, task_decorator_factory +from airflow.operators.email import EmailOperator +from airflow.utils.context import Context, context_merge +from airflow.utils.operator_helpers import determine_kwargs +from airflow.utils.types import NOTSET + + +class _EmailDecoratedOperator(DecoratedOperator, EmailOperator): Review Comment: Should this be here? I think it should be in smtp provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 📧 Add email decorator [airflow]
eladkal commented on code in PR #41076: URL: https://github.com/apache/airflow/pull/41076#discussion_r1694229555 ## airflow/decorators/email.py: ## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import warnings +from typing import Any, Callable, Collection, Mapping, Sequence + +from airflow.decorators.base import DecoratedOperator, TaskDecorator, task_decorator_factory +from airflow.operators.email import EmailOperator +from airflow.utils.context import Context, context_merge +from airflow.utils.operator_helpers import determine_kwargs +from airflow.utils.types import NOTSET + + +class _EmailDecoratedOperator(DecoratedOperator, EmailOperator): Review Comment: Should this be here? I think it should be in smtp provider https://github.com/apache/airflow/blob/main/airflow/providers/smtp/operators/smtp.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
