Re: [PR] AIP-38 Fix UI following Vite upgrade [airflow]
pierrejeambrun commented on PR #45934: URL: https://github.com/apache/airflow/pull/45934#issuecomment-2608141709 I agree that's the implicit interface definition. We might rely on a bug. But here most users will have an issue upgrading, and we rely on the default behavior... changing the default is quite impactful IMO. But anyway, all good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] AIP-38 Fix UI following Vite upgrade [airflow]
potiuk commented on PR #45934: URL: https://github.com/apache/airflow/pull/45934#issuecomment-2607635153 Simply -> Semver does not 100% guarantee that after upgrade to patchlevel version everything will work as it did. If it did, then it means that applying any fix is impossible - because someone could have relied on that thing being broken :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] AIP-38 Fix UI following Vite upgrade [airflow]
potiuk commented on PR #45934: URL: https://github.com/apache/airflow/pull/45934#issuecomment-2607630102 > cc: @potiuk (It appears that Vite is a little bit more flexible on semver definition 😂, even if they seem to follow Semver stricktly https://vite.dev/releases) Actually - they are pretty conistent. The change in question is a fix - so it turned out the previous default was wrong and this one is fixing it:  This is precisely as I always repeat - pretty much any change is breaking, otherwise it would not be a change. Change == Behaviour change, which means that if you rely on some behaviour, it will break your use. But breaking your use does not mean breaking semver, it means that there was some unintentional (usually buggy) behaviour that you relied on which has been classified by the authors are exactly this - unintentional, or even buggy. And they fixed :). So. ... All is good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] AIP-38 Fix UI following Vite upgrade [airflow]
pierrejeambrun merged PR #45934: URL: https://github.com/apache/airflow/pull/45934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] AIP-38 Fix UI following Vite upgrade [airflow]
pierrejeambrun commented on PR #45934: URL: https://github.com/apache/airflow/pull/45934#issuecomment-2607543902 cc: @potiuk (Vite is a little bit more flexible on semver it appears 😂) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
