Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2745316241  Seems like we hit the workflow limit :( I will come up with some ideas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2755591598 Okay, the pre-commit hook forced me to add it as a workspace in all providers. So airflow-ctl seems to need to be defined under as a dev in all providers. Any feedback is welcome There are still a couple of steps to make it all green :crossed_fingers: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2755406538 > > I couldn't properly trigger the full-tests even though I have added the label and reopened the issue twice. I will check a bit, please let me know if anyone knows the problem. I will later try to push dummy commits to test the functionality instead. Then I can again squash my commits locally so that they won't be visible on the main. > > Add canary label then it behaves as schedule run :) That's a good one :) Thanks! I committed a dummy change and just saw your message :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2755341526 I couldn't properly trigger the full-tests even though I have added the label and reopened the issue twice. I will check a bit, please let me know if anyone knows the problem. I will later try to push dummy commits to test the functionality instead. Then I can again squash my commits locally so that they won't be visible on the main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
gopidesupavan commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2755391882 > I couldn't properly trigger the full-tests even though I have added the label and reopened the issue twice. I will check a bit, please let me know if anyone knows the problem. I will later try to push dummy commits to test the functionality instead. Then I can again squash my commits locally so that they won't be visible on the main. Add canary label then it behaves as schedule run :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 closed pull request #48099: AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands URL: https://github.com/apache/airflow/pull/48099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 closed pull request #48099: AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands URL: https://github.com/apache/airflow/pull/48099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2749292583 I closed and reopened to trigger the full tests since it touches those parts. Good to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on code in PR #48099:
URL: https://github.com/apache/airflow/pull/48099#discussion_r2009099120
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -611,6 +613,7 @@ def prepare_airflow_distributions(
get_console().print("[success]Successfully prepared Airflow packages")
+# TODO BUGRA CHECK
Review Comment:
Okay, added the command method via again merging non-core distributions
other than providers of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on PR #48099: URL: https://github.com/apache/airflow/pull/48099#issuecomment-2746155748 > Looks good, thanks! Just a small nit for a typo. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
bugraoz93 commented on code in PR #48099:
URL: https://github.com/apache/airflow/pull/48099#discussion_r2009083256
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -611,6 +613,7 @@ def prepare_airflow_distributions(
get_console().print("[success]Successfully prepared Airflow packages")
+# TODO BUGRA CHECK
Review Comment:
No, I missed that :facepalm: That's for me and it is for this PR. I need to
include that method for airflowctl too because it is built before unit tests in
the CI. I will add that method and remove TODO :)
https://github.com/apache/airflow/pull/48099/files#diff-4d1496a96cc8fbdb27e05801df30a444a77bcb80683a2022bc1b41cb23610bdaR88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] AIP-81 airflowctl Include CI/breeze unit-testing and some distribution commands [airflow]
jason810496 commented on code in PR #48099:
URL: https://github.com/apache/airflow/pull/48099#discussion_r2009006362
##
dev/breeze/doc/05_test_commands.rst:
##
@@ -177,6 +177,26 @@ Here is the detailed set of options for the ``breeze
testing task-sdk-tests`` co
:alt: Breeze testing task-sdk-tests
+Using ``breeze testing airflow-ctl-tests`` command
+...
+
+The ``breeze testing airflow-ctl-tests`` command is allows you to run tests
for Airflow CTL without
+initializing database. The Airflow CTL should not need database to be started
so this acts as a
+good check to see if the Airflow CTL tests are working properly.
Review Comment:
```suggestion
The ``breeze testing airflow-ctl-tests`` command allows you to run tests for
Airflow CTL without
initializing database. Airflow CTL should not require a database to start,
so this acts as a
good check to see if the Airflow CTL tests are working properly.
```
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -611,6 +613,7 @@ def prepare_airflow_distributions(
get_console().print("[success]Successfully prepared Airflow packages")
+# TODO BUGRA CHECK
Review Comment:
Is this TODO intended to be left?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
