Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4049718523 I'd propose to skip backporting as of complexity, having this on main is sufficient in my view. Let me know otherwise... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl merged PR #61615: URL: https://github.com/apache/airflow/pull/61615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
github-actions[bot] commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4049375732 ### Backport failed to create: v3-1-test. View the failure log Run details Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x) the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches. In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel. Status Branch Result ❌ v3-1-test https://github.com/apache/airflow/commit/a29a5dfdb614c2143d72ebd5c7200e53bbe12c6b";> You can attempt to backport this manually by running: ```bash cherry_picker a29a5df v3-1-test ``` This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4045321227 > > Could you re-run the failed jobs when the `main` issues are resolved? Thanks! > > No. You need to rebase. Thanks. All green now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
potiuk commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4043710323 > Could you re-run the failed jobs when the `main` issues are resolved? Thanks! No. You need to rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4043646720 @potiuk All 3 failing checks also fail on `main` right now (or are CI infra flakes): - **Static checks**: `Validate provider.yaml files` is broken on `main` too (different error, `openai/provider.yaml` schema validation) - **K8S CeleryExecutor-3.10-v1.30.13**: Also failing on `main` with Helm upgrade race condition - **Provider compat Compat 3.0.6**: `mongo:latest` image pull failure on the runner (passes on `main`) Could you re-run the failed jobs when the `main` issues are resolved? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
potiuk commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4035043038 @andreahlert This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Pre-commit / static checks**: Failing: CI image checks / Static checks. Run `prek run --from-ref main` locally to find and fix issues. See [Pre-commit / static checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst). > **Note:** Your branch is **177 commits behind `main`**. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results. **What to do next:** - The comment informs you what you need to do. - Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed. - Maintainers will then proceed with a normal review. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
potiuk commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4033430786 There are still unrelated changes and conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on code in PR #61615: URL: https://github.com/apache/airflow/pull/61615#discussion_r2895278373 ## providers/keycloak/.pre-commit-config.yaml: ## @@ -26,7 +26,7 @@ repos: hooks: - id: generate-openapi-spec-keycloak name: Generate the FastAPI API spec for Keycloak -language: python -entry: ../../scripts/ci/prek/generate_openapi_spec_providers.py keycloak +language: system +entry: python3 ../../scripts/ci/prek/generate_openapi_spec_providers.py keycloak Review Comment: Reverted. That change wasn’t intentional... it likely came from a merge or from staging multiple fixes together (yamllint + keycloak). Thanks for catching it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on code in PR #61615: URL: https://github.com/apache/airflow/pull/61615#discussion_r2892449218 ## providers/keycloak/.pre-commit-config.yaml: ## @@ -26,7 +26,7 @@ repos: hooks: - id: generate-openapi-spec-keycloak name: Generate the FastAPI API spec for Keycloak -language: python -entry: ../../scripts/ci/prek/generate_openapi_spec_providers.py keycloak +language: system +entry: python3 ../../scripts/ci/prek/generate_openapi_spec_providers.py keycloak Review Comment: Why this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4006632852 > Timeouts can happen... restarted... Thanks. All green, as I like :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-4000322639 Timeouts can happen... restarted... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3997754341 @potiuk could you take a look? I think that [Tests / Integration and System Tests / Integration core redis (pull_request)](https://github.com/apache/airflow/actions/runs/22669428698/job/65710744332?pr=61615)Cancelled after 30m Is just taking some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
kunaljubce commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2882634476
##
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##
@@ -1734,7 +1734,7 @@ def _logs(python: str, kubernetes_version: str):
@kubernetes_group.command(
name="logs",
-help=f"Dump k8s logs to ${{TMP_DIR}}{os.sep}kind_logs_
directory "
+help="Dump k8s logs to ${TMP_DIR}/kind_logs_ directory "
Review Comment:
Really good job on the PR though 🍾
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2882631234
##
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##
@@ -1734,7 +1734,7 @@ def _logs(python: str, kubernetes_version: str):
@kubernetes_group.command(
name="logs",
-help=f"Dump k8s logs to ${{TMP_DIR}}{os.sep}kind_logs_
directory "
+help="Dump k8s logs to ${TMP_DIR}/kind_logs_ directory "
Review Comment:
Good point. I'll update it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
kunaljubce commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2882618959
##
dev/breeze/src/airflow_breeze/commands/kubernetes_commands.py:
##
@@ -1734,7 +1734,7 @@ def _logs(python: str, kubernetes_version: str):
@kubernetes_group.command(
name="logs",
-help=f"Dump k8s logs to ${{TMP_DIR}}{os.sep}kind_logs_
directory "
+help="Dump k8s logs to ${TMP_DIR}/kind_logs_ directory "
Review Comment:
@andreahlert I think this should be `{os.sep}` to make the message platform
agnostic. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3987217950 Ah, just a small nit... small rebase or merge and anothe r`prek` run, then I hope this is green soon. Close by! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2843309340
##
Dockerfile.ci:
##
@@ -1569,7 +1571,7 @@ ENV DEV_APT_COMMAND=${DEV_APT_COMMAND} \
ARG AIRFLOW_PYTHON_VERSION="3.12.12"
ENV AIRFLOW_PYTHON_VERSION=${AIRFLOW_PYTHON_VERSION}
-ENV GOLANG_MAJOR_MINOR_VERSION="1.26.0"
+ENV GOLANG_MAJOR_MINOR_VERSION="1.25.7"
Review Comment:
```suggestion
ENV GOLANG_MAJOR_MINOR_VERSION="1.26.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2843307453
##
Dockerfile.ci:
##
@@ -1569,7 +1571,7 @@ ENV DEV_APT_COMMAND=${DEV_APT_COMMAND} \
ARG AIRFLOW_PYTHON_VERSION="3.12.12"
ENV AIRFLOW_PYTHON_VERSION=${AIRFLOW_PYTHON_VERSION}
-ENV GOLANG_MAJOR_MINOR_VERSION="1.26.0"
+ENV GOLANG_MAJOR_MINOR_VERSION="1.25.7"
Review Comment:
Still looking like an uups here in this line ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
potiuk commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3911255702 Almost - static checks and some dep conflicts for UV version ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3910483287 > Lots of conflicts to resolve ? Sorry for the delay on this one, it turned into one of those “why are there 500 files in my diff” situations 😅 The real conflict was in `dev/breeze/src/airflow_breeze/global_constants.py`, and I kept the current `main` value for the providers matrix (`informatica` + `common.ai`) so we don’t reintroduce unrelated rebase artifacts. I think we're good to go. just finishing the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
potiuk commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3905304893 Lots of conflicts to resolve ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2795579001
##
Dockerfile.ci:
##
@@ -1569,7 +1571,7 @@ ENV DEV_APT_COMMAND=${DEV_APT_COMMAND} \
ARG AIRFLOW_PYTHON_VERSION="3.12.12"
ENV AIRFLOW_PYTHON_VERSION=${AIRFLOW_PYTHON_VERSION}
-ENV GOLANG_MAJOR_MINOR_VERSION="1.26.0"
+ENV GOLANG_MAJOR_MINOR_VERSION="1.25.7"
Review Comment:
This also looks like a rebase "uups"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2795004095
##
dev/breeze/src/airflow_breeze/global_constants.py:
##
@@ -743,7 +745,7 @@ def get_airflow_extras():
{
"python-version": "3.10",
"airflow-version": "2.11.0",
-"remove-providers": "common.messaging edge3 fab git keycloak
common.ai",
+"remove-providers": "common.messaging edge3 fab git keycloak",
"run-unit-tests": "true",
},
Review Comment:
Yep, you're right. That slipped in from a rebase, not intentional. I'll
clean it up in the next push.
##
dev/breeze/src/airflow_breeze/global_constants.py:
##
@@ -219,7 +221,7 @@
ALLOWED_INSTALL_MYSQL_CLIENT_TYPES = ["mariadb"]
PIP_VERSION = "26.0.1"
-UV_VERSION = "0.10.2"
+UV_VERSION = "0.10.0"
Review Comment:
Same thing, merge artifact. Will revert both in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jason810496 commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2794886044
##
dev/breeze/src/airflow_breeze/global_constants.py:
##
@@ -743,7 +745,7 @@ def get_airflow_extras():
{
"python-version": "3.10",
"airflow-version": "2.11.0",
-"remove-providers": "common.messaging edge3 fab git keycloak
common.ai",
+"remove-providers": "common.messaging edge3 fab git keycloak",
"run-unit-tests": "true",
},
Review Comment:
The changes seems to be unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jason810496 commented on code in PR #61615: URL: https://github.com/apache/airflow/pull/61615#discussion_r2794895401 ## dev/breeze/src/airflow_breeze/global_constants.py: ## @@ -219,7 +221,7 @@ ALLOWED_INSTALL_MYSQL_CLIENT_TYPES = ["mariadb"] PIP_VERSION = "26.0.1" -UV_VERSION = "0.10.2" +UV_VERSION = "0.10.0" Review Comment: Same here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3866994637 > I thought about putting the URL directly in `--backend`, but it felt a bit tricky since that parameter drives other things too (docker image, test configs, CI matrix). Mixing a backend name with a raw connection string would need extra parsing to tell them apart, and we'd lose Click's enum validation for the known backends. > > Keeping `--custom-db-url` separate also maps nicely to the `AIRFLOW__DATABASE__SQL_ALCHEMY_CONN` env fallback. But if you and @potiuk prefer the single-parameter route, I can refactor - no strong feelings either way. That makes totally sense! So let's go with the current proposal in the PR. That is also OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2779125773
##
scripts/docker/entrypoint_ci.sh:
##
@@ -121,6 +121,8 @@ function environment_initialization() {
echo " * ${COLOR_BLUE}Airflow backend:${COLOR_RESET} MySQL:
${MYSQL_VERSION}"
elif [[ ${BACKEND=} == "sqlite" ]]; then
echo " * ${COLOR_BLUE}Airflow backend:${COLOR_RESET} Sqlite"
+elif [[ ${BACKEND=} == "custom" ]]; then
+echo " * ${COLOR_BLUE}Airflow backend:${COLOR_RESET} Custom"
Review Comment:
Yeah, makes sense. I'll add a log line with the DB URL (password masked) so
it's clear what Breeze is connecting to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3866989243 Thanks, glad you like it! I thought about putting the URL directly in `--backend`, but it felt a bit tricky since that parameter drives other things too (docker image, test configs, CI matrix). Mixing a backend name with a raw connection string would need extra parsing to tell them apart, and we'd lose Click's enum validation for the known backends. Keeping `--custom-db-url` separate also maps nicely to the `AIRFLOW__DATABASE__SQL_ALCHEMY_CONN` env fallback. But if you and @potiuk prefer the single-parameter route, I can refactor - no strong feelings either way. Will regenerate the docs and address your inline comment too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
jscheffl commented on code in PR #61615:
URL: https://github.com/apache/airflow/pull/61615#discussion_r2779064369
##
scripts/docker/entrypoint_ci.sh:
##
@@ -121,6 +121,8 @@ function environment_initialization() {
echo " * ${COLOR_BLUE}Airflow backend:${COLOR_RESET} MySQL:
${MYSQL_VERSION}"
elif [[ ${BACKEND=} == "sqlite" ]]; then
echo " * ${COLOR_BLUE}Airflow backend:${COLOR_RESET} Sqlite"
+elif [[ ${BACKEND=} == "custom" ]]; then
+echo " * ${COLOR_BLUE}Airflow backend:${COLOR_RESET} Custom"
Review Comment:
Would it make sense to print the used DB URL for confirmation here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
andreahlert commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3865606259 Good point! I'll add a `--custom-db-url` / `-C` parameter that accepts the SQLAlchemy connection string directly, with `AIRFLOW__DATABASE__SQL_ALCHEMY_CONN` as the environment variable fallback. When `--backend=custom` is used without either, Breeze will show a clear error. I went with `--custom-db-url` for naming, but happy to rename if you prefer something different. Will update the PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add --backend=custom option for external databases in Breeze [airflow]
potiuk commented on PR #61615: URL: https://github.com/apache/airflow/pull/61615#issuecomment-3865516884 I think if we do that, then there should be a parameter defined to provide the sqlalchemy URL to connect to - rather than relying on the env variable setting (and this new paraemeter should have an env fallback) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
