Re: [PR] Add aliases for rebranded Google services [airflow]
shahar1 merged PR #66344: URL: https://github.com/apache/airflow/pull/66344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add aliases for rebranded Google services [airflow]
shahar1 commented on PR #66344: URL: https://github.com/apache/airflow/pull/66344#issuecomment-4427028849 Rebased before merging as some unrelated tests failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add aliases for rebranded Google services [airflow]
VladaZakharova commented on code in PR #66344: URL: https://github.com/apache/airflow/pull/66344#discussion_r3196106502 ## providers/google/src/airflow/providers/google/cloud/operators/dataplex.py: ## @@ -4218,3 +4218,51 @@ def execute(self, context: Context): except Exception as ex: raise AirflowException(ex) return Entry.to_dict(entry) + + +KnowledgeCatalogCreateTaskOperator: TypeAlias = DataplexCreateTaskOperator Review Comment: makes sense, thank you, i made the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add aliases for rebranded Google services [airflow]
shahar1 commented on code in PR #66344: URL: https://github.com/apache/airflow/pull/66344#discussion_r3190309938 ## providers/google/src/airflow/providers/google/cloud/operators/dataplex.py: ## @@ -4218,3 +4218,51 @@ def execute(self, context: Context): except Exception as ex: raise AirflowException(ex) return Entry.to_dict(entry) + + +KnowledgeCatalogCreateTaskOperator: TypeAlias = DataplexCreateTaskOperator Review Comment: Similar to composer vs. managed airflow - aliases should be under a new module (same goes for the other APIs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
