Re: [PR] Add regex validation for table names in 'bulk_load_custom' [airflow]
github-actions[bot] closed pull request #50764: Add regex validation for table names in 'bulk_load_custom' URL: https://github.com/apache/airflow/pull/50764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add regex validation for table names in 'bulk_load_custom' [airflow]
github-actions[bot] commented on PR #50764: URL: https://github.com/apache/airflow/pull/50764#issuecomment-3040476934 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add regex validation for table names in 'bulk_load_custom' [airflow]
kdsjZh commented on code in PR #50764: URL: https://github.com/apache/airflow/pull/50764#discussion_r2100090311 ## providers/google/src/airflow/providers/google/cloud/operators/bigquery.py: ## @@ -686,7 +686,7 @@ def __init__( ) self.table = table self.column_mapping = column_mapping -self.partition_clause = partition_clause +self.partition_clause = _initialize_partition_clause(partition_clause) Review Comment: I revoke the second change and will update the second hard in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add regex validation for table names in 'bulk_load_custom' [airflow]
eladkal commented on code in PR #50764: URL: https://github.com/apache/airflow/pull/50764#discussion_r2100074248 ## providers/google/src/airflow/providers/google/cloud/operators/bigquery.py: ## @@ -686,7 +686,7 @@ def __init__( ) self.table = table self.column_mapping = column_mapping -self.partition_clause = partition_clause +self.partition_clause = _initialize_partition_clause(partition_clause) Review Comment: can you extract the google changes to separated PR? We generate release notes from the commit message and the commit message is for mysql only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add regex validation for table names in 'bulk_load_custom' [airflow]
kdsjZh commented on PR #50764: URL: https://github.com/apache/airflow/pull/50764#issuecomment-2893914267 Hi, the second commit is a hardening for an incomplete fix in #48098. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add regex validation for table names in 'bulk_load_custom' [airflow]
boring-cyborg[bot] commented on PR #50764: URL: https://github.com/apache/airflow/pull/50764#issuecomment-2890593363 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
