Re: [PR] Add script to move providers to the new directory structure [airflow]
gopidesupavan commented on PR #45945: URL: https://github.com/apache/airflow/pull/45945#issuecomment-2608472821 Cool :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add script to move providers to the new directory structure [airflow]
potiuk merged PR #45945: URL: https://github.com/apache/airflow/pull/45945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add script to move providers to the new directory structure [airflow]
potiuk commented on code in PR #45945: URL: https://github.com/apache/airflow/pull/45945#discussion_r1925970317 ## .github/boring-cyborg.yml: ## @@ -27,8 +27,8 @@ labelPRBasedOnFilePath: - providers/tests/alibaba/**/* - providers/tests/system/alibaba/**/* - provider:amazon-aws: -- providers/src/airflow/providers/amazon/aws/**/* Review Comment: We might want to change it in the future - but for now tmigration scripts expect consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add script to move providers to the new directory structure [airflow]
potiuk commented on code in PR #45945: URL: https://github.com/apache/airflow/pull/45945#discussion_r1925969308 ## .github/boring-cyborg.yml: ## @@ -27,8 +27,8 @@ labelPRBasedOnFilePath: - providers/tests/alibaba/**/* - providers/tests/system/alibaba/**/* - provider:amazon-aws: -- providers/src/airflow/providers/amazon/aws/**/* Review Comment: Becasue it's inconsistent with all the other providers. We hae `apache-airflow-providers-amazon` not `apache-airlfow-providers-amazon-aws` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add script to move providers to the new directory structure [airflow]
eladkal commented on code in PR #45945: URL: https://github.com/apache/airflow/pull/45945#discussion_r1925945347 ## .github/boring-cyborg.yml: ## @@ -27,8 +27,8 @@ labelPRBasedOnFilePath: - providers/tests/alibaba/**/* - providers/tests/system/alibaba/**/* - provider:amazon-aws: -- providers/src/airflow/providers/amazon/aws/**/* Review Comment: Why? Ar some point there can be amazon provider that is not aws (integration with sellers API for Amazon marketplaces) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add script to move providers to the new directory structure [airflow]
potiuk commented on PR #45945: URL: https://github.com/apache/airflow/pull/45945#issuecomment-2608217817 OK. I have the script that performs 9x% of provider's migration. There are few small fixes needed in individual providers - like spellchecking fixes, somr inclusive language changes etc. - all should be found by pre-commits. After merging, I will try it on one or two providers and will ask people to help with migrating the rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
