Re: [PR] Airflow mac [airflow]
praneeth552 commented on PR #50479: URL: https://github.com/apache/airflow/pull/50479#issuecomment-2875193381 Hi @potiuk , I've updated the README.md to keep the INSTALLING.md file as requested and moved the link to it below the section that is automatically included in the PyPI description. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Airflow mac [airflow]
potiuk commented on PR #50479: URL: https://github.com/apache/airflow/pull/50479#issuecomment-2874278411 I know we are going back and forth, but this is something I wanted to avoid to make the INSTALLATION in the main readme and link to it in PyPI. The last comment I had was really: * leave the INSTALLING file * but move the link down - below the part of the README that is automatically copied to PyPI readme. How it works - our pre-commit is extracting part of the README (marked by appropriate comments) And copies it to PyPI readme, so the description of yours is OK to be linked from main README, but this link should be outside of the part that gets copied to PyPI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Airflow mac [airflow]
praneeth552 commented on PR #50479: URL: https://github.com/apache/airflow/pull/50479#issuecomment-2873632450 Dear @potiuk , Thank you for your feedback. I've updated the documentation as per your suggestions. The "macOS Setup Instructions" section is now "Local Development Setup," and the content from INSTALLING.md has been integrated. I hope these changes address your concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Airflow mac [airflow]
potiuk commented on PR #50479: URL: https://github.com/apache/airflow/pull/50479#issuecomment-2873064303 As discussed before- > this will not work when placed in PyPI - the relative link will not work - so ideally move it out of the part that is copied to PyPI readme. Also - I think there is very little point in naming it as "Apple/MacOS silicon" - as written now, this is a pretty nice , generic desription of installation that should work elsewhere. Brew is the only (potentially) MacOS specific things there (and none of it targets Sillicon) - but brew also works on linux (I use it) - so it might be mentioned as one of the ways of installing PyEnv. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
