Re: [PR] Align layout in trigger form with flexible form [airflow]
jscheffl merged PR #46596: URL: https://github.com/apache/airflow/pull/46596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Align layout in trigger form with flexible form [airflow]
jscheffl commented on PR #46596: URL: https://github.com/apache/airflow/pull/46596#issuecomment-2660244128 Thanks @shubhamraj-git for pushing some changes! I think now as the component is extracted this leaves the option to move back the JavaScript into the component w/o linter errors. Let me reverse this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Align layout in trigger form with flexible form [airflow]
pierrejeambrun commented on code in PR #46596:
URL: https://github.com/apache/airflow/pull/46596#discussion_r1949149192
##
airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##
@@ -224,7 +216,36 @@ const TriggerDAGForm = ({ dagId, onClose, open }:
TriggerDAGFormProps) => {
render={({ field }) => (
Dag Run Notes
-
+) => {
+field.value = event.target.value;
+ }}
+ value={field.value}
+>
+
+{Boolean(field.value) ? (
+ {field.value}
+) : (
+ Add a note...
+)}
+
+
+
Review Comment:
Good idea.
Ideally I think we want to extract a component from this `Editable' for
markdown content input.
I feel like this will be needed to a different places.
##
airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##
@@ -224,7 +216,36 @@ const TriggerDAGForm = ({ dagId, onClose, open }:
TriggerDAGFormProps) => {
render={({ field }) => (
Dag Run Notes
-
+) => {
+field.value = event.target.value;
+ }}
+ value={field.value}
+>
+
+{Boolean(field.value) ? (
+ {field.value}
+) : (
+ Add a note...
+)}
+
+
+
Review Comment:
Good idea.
Ideally I think we want to extract a component from this `Editable' for
markdown content input.
I feel like this will be needed at different places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Align layout in trigger form with flexible form [airflow]
pierrejeambrun commented on code in PR #46596:
URL: https://github.com/apache/airflow/pull/46596#discussion_r1949149192
##
airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##
@@ -224,7 +216,36 @@ const TriggerDAGForm = ({ dagId, onClose, open }:
TriggerDAGFormProps) => {
render={({ field }) => (
Dag Run Notes
-
+) => {
+field.value = event.target.value;
+ }}
+ value={field.value}
+>
+
+{Boolean(field.value) ? (
+ {field.value}
+) : (
+ Add a note...
+)}
+
+
+
Review Comment:
Good idea.
Ideally I think we want to extract a component from this `Editable/Preview'
for markdown content input.
I feel like this will be needed to a different places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
