Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
eladkal merged PR #46219: URL: https://github.com/apache/airflow/pull/46219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
eladkal commented on PR #46219: URL: https://github.com/apache/airflow/pull/46219#issuecomment-2639905874 Merging. Failures ade about Amazon DMS not related to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
hussein-awala commented on PR #46219: URL: https://github.com/apache/airflow/pull/46219#issuecomment-2637834691 > @hussein-awala can you rebase and resolve conflicts? I'd like to include this in the next provider wave it's ready, I'll merge once the tests are green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
eladkal commented on PR #46219: URL: https://github.com/apache/airflow/pull/46219#issuecomment-2637676959 @hussein-awala can you rebase and resolve conflicts? I'd like to include this in the next provider wave -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
eladkal commented on code in PR #46219: URL: https://github.com/apache/airflow/pull/46219#discussion_r1938421555 ## providers/src/airflow/providers/smtp/provider.yaml: ## Review Comment: Actually no need to do that :) I'll do it during release time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
eladkal commented on code in PR #46219: URL: https://github.com/apache/airflow/pull/46219#discussion_r1937067741 ## generated/provider_dependencies.json: ## @@ -888,7 +888,7 @@ "deps": [ "apache-airflow>=2.9.0", "dnspython>=1.13.0", - "pymongo>=4.0.0" + "pymongo>=4.0.0,!=4.11" Review Comment: it was fixed in main already -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
hussein-awala commented on code in PR #46219: URL: https://github.com/apache/airflow/pull/46219#discussion_r1935320688 ## generated/provider_dependencies.json: ## @@ -888,7 +888,7 @@ "deps": [ "apache-airflow>=2.9.0", "dnspython>=1.13.0", - "pymongo>=4.0.0" + "pymongo>=4.0.0,!=4.11" Review Comment: It was updated by static checks/pre-commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] BREAKING CHANGE: replace Airflow config by conx extras in SMTP provider [airflow]
eladkal commented on code in PR #46219: URL: https://github.com/apache/airflow/pull/46219#discussion_r1933425961 ## providers/src/airflow/providers/smtp/provider.yaml: ## Review Comment: add also 2.0.0 in the version section ## generated/provider_dependencies.json: ## @@ -888,7 +888,7 @@ "deps": [ "apache-airflow>=2.9.0", "dnspython>=1.13.0", - "pymongo>=4.0.0" + "pymongo>=4.0.0,!=4.11" Review Comment: unrelated change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
