Re: [PR] Breeze exit on incompatible arguments [airflow]
potiuk commented on PR #59148: URL: https://github.com/apache/airflow/pull/59148#issuecomment-3623684367 Nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Breeze exit on incompatible arguments [airflow]
github-actions[bot] commented on PR #59148: URL: https://github.com/apache/airflow/pull/59148#issuecomment-3621992656 ### Backport failed to create: v3-1-test. View the failure log Run details Status Branch Result ❌ v3-1-test https://github.com/apache/airflow/commit/236dab6406e55f88b879f69154e54f2763ce5d3b";> You can attempt to backport this manually by running: ```bash cherry_picker 236dab6 v3-1-test ``` This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Breeze exit on incompatible arguments [airflow]
jscheffl merged PR #59148: URL: https://github.com/apache/airflow/pull/59148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Breeze exit on incompatible arguments [airflow]
jscheffl commented on code in PR #59148: URL: https://github.com/apache/airflow/pull/59148#discussion_r2596235677 ## dev/breeze/src/airflow_breeze/commands/developer_commands.py: ## @@ -628,6 +628,14 @@ def start_airflow( ) skip_assets_compilation = True +if dev_mode and use_airflow_version: +get_console().print( +"[Error][bold red] You cannot set Airflow version in dev mode! Consider switching to the respective" Review Comment: Applying suggestion and then LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Breeze exit on incompatible arguments [airflow]
choo121600 commented on PR #59148: URL: https://github.com/apache/airflow/pull/59148#issuecomment-3621833480 This PR is based on the context from this Slack thread, right? Adding it here for the reviewers ;) https://apache-airflow.slack.com/archives/CQ9QHSFQX/p1764828284189619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Breeze exit on incompatible arguments [airflow]
choo121600 commented on code in PR #59148: URL: https://github.com/apache/airflow/pull/59148#discussion_r2596166642 ## dev/breeze/src/airflow_breeze/commands/developer_commands.py: ## @@ -628,6 +628,14 @@ def start_airflow( ) skip_assets_compilation = True +if dev_mode and use_airflow_version: +get_console().print( +"[Error][bold red] You cannot set Airflow version in dev mode! Consider switching to the respective" Review Comment: ```suggestion "[error]You cannot set Airflow version in dev mode! Consider switching to the respective" ``` ## dev/breeze/src/airflow_breeze/commands/developer_commands.py: ## @@ -628,6 +628,14 @@ def start_airflow( ) skip_assets_compilation = True +if dev_mode and use_airflow_version: +get_console().print( +"[Error][bold red] You cannot set Airflow version in dev mode! Consider switching to the respective" Review Comment: Nit suggestion: I think you can use [error] instead of [Error][bold red] for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
