Re: [PR] Change starlette import to fastapi [airflow]
boring-cyborg[bot] commented on PR #60382: URL: https://github.com/apache/airflow/pull/60382#issuecomment-3736829314 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
uranusjr merged PR #60382: URL: https://github.com/apache/airflow/pull/60382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
unknowntpo commented on code in PR #60382: URL: https://github.com/apache/airflow/pull/60382#discussion_r2679222454 ## airflow-core/src/airflow/api_fastapi/compat.py: ## Review Comment: I think we still need this try-catch. The try/except in `compat.py` is for backward compatibility with older FastAPI versions when running "Low dep tests" (`uv sync --resolution lowest-direct`). FastAPI 0.128.0 (our minimum version) requires starlette>=0.40.0. With "Low dep tests" (uv sync --resolution lowest-direct), starlette 0.40.0 is installed, which only has `HTTP_422_UNPROCESSABLE_ENTITY`. So we need this fallback for backward compatibility. Note that the `HTTP_422_UNPROCESSABLE_ENTITY` was deprecated in Starlette 0.48.0 and renamed to `HTTP_422_UNPROCESSABLE_CONTENT` to align with RFC 9110 (HTTP Semantics). References: - Starlette release notes: https://www.starlette.io/release-notes/ - RFC 9110: https://www.rfc-editor.org/rfc/rfc9110#status.422 - failed CI: Lowest Deps test: https://github.com/apache/airflow/actions/runs/20886590921/job/60010997212?pr=60382#step:8:14217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
jason810496 commented on code in PR #60382: URL: https://github.com/apache/airflow/pull/60382#discussion_r2679257180 ## airflow-core/src/airflow/api_fastapi/compat.py: ## Review Comment: > I think we still need tis try-catch. Yes, we still need try–catch for FastAPI compatibility. Thank you for adding the dependency details as a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
unknowntpo commented on code in PR #60382: URL: https://github.com/apache/airflow/pull/60382#discussion_r2679222454 ## airflow-core/src/airflow/api_fastapi/compat.py: ## Review Comment: I think we still need tis try-catch. The try/except in `compat.py` is for backward compatibility with older FastAPI versions when running "Low dep tests" (`uv sync --resolution lowest-direct`). FastAPI 0.128.0 (our minimum version) requires starlette>=0.40.0. With "Low dep tests" (uv sync --resolution lowest-direct), starlette 0.40.0 is installed, which only has `HTTP_422_UNPROCESSABLE_ENTITY`. So we need this fallback for backward compatibility. Note that the `HTTP_422_UNPROCESSABLE_ENTITY` was deprecated in Starlette 0.48.0 and renamed to `HTTP_422_UNPROCESSABLE_CONTENT` to align with RFC 9110 (HTTP Semantics). References: - Starlette release notes: https://www.starlette.io/release-notes/ - RFC 9110: https://www.rfc-editor.org/rfc/rfc9110#status.422 - failed CI: Lowest Deps test: https://github.com/apache/airflow/actions/runs/20886590921/job/60010997212?pr=60382#step:8:14217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
unknowntpo commented on code in PR #60382: URL: https://github.com/apache/airflow/pull/60382#discussion_r2679222454 ## airflow-core/src/airflow/api_fastapi/compat.py: ## Review Comment: I think we still need tis try-catch. The try/except in `compat.py` is for backward compatibility with older FastAPI versions when running "Low dep tests" (`uv sync --resolution lowest-direct`). The `HTTP_422_UNPROCESSABLE_ENTITY` was deprecated in Starlette 0.48.0 and renamed to `HTTP_422_UNPROCESSABLE_CONTENT` to align with RFC 9110 (HTTP Semantics). References: - Starlette release notes: https://www.starlette.io/release-notes/ - RFC 9110: https://www.rfc-editor.org/rfc/rfc9110#status.422 - failed CI: Lowest Deps test: https://github.com/apache/airflow/actions/runs/20886590921/job/60010997212?pr=60382#step:8:14217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
unknowntpo commented on code in PR #60382: URL: https://github.com/apache/airflow/pull/60382#discussion_r2679115949 ## airflow-core/src/airflow/api_fastapi/compat.py: ## Review Comment: [Related comment](https://github.com/apache/airflow/pull/58127#discussion_r2671043614) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
unknowntpo commented on code in PR #60382: URL: https://github.com/apache/airflow/pull/60382#discussion_r2679115949 ## airflow-core/src/airflow/api_fastapi/compat.py: ## Review Comment: [Relate](https://github.com/apache/airflow/pull/58127#discussion_r2671043614) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Change starlette import to fastapi [airflow]
boring-cyborg[bot] commented on PR #60382: URL: https://github.com/apache/airflow/pull/60382#issuecomment-3733727324 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
