Re: [PR] Correctly handle rendering dag tags when tags are 1 more than max [airflow]
pierrejeambrun commented on PR #50669: URL: https://github.com/apache/airflow/pull/50669#issuecomment-2890942538 I would only solve the current case of a missing ',' separator when there is `max + 1` tags, between `max` and `max + 1` items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Correctly handle rendering dag tags when tags are 1 more than max [airflow]
amoghrajesh commented on PR #50669: URL: https://github.com/apache/airflow/pull/50669#issuecomment-2890267027 Definitely yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Correctly handle rendering dag tags when tags are 1 more than max [airflow]
amoghrajesh commented on PR #50669: URL: https://github.com/apache/airflow/pull/50669#issuecomment-2890328338 @pierrejeambrun / @bbovenzi how do you suggest we proceed with this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Correctly handle rendering dag tags when tags are 1 more than max [airflow]
amoghrajesh commented on PR #50669: URL: https://github.com/apache/airflow/pull/50669#issuecomment-2890160427 There's one thing though -- "+1 more" will be much much shorter than having a tag of max_len, defined as `TAG_MAX_LEN = 100`. So should we have some logic that something in between? Show the min of the two? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
