Re: [PR] Default 'once' start_date to 'now' when None [airflow]
uranusjr merged PR #50760: URL: https://github.com/apache/airflow/pull/50760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default 'once' start_date to 'now' when None [airflow]
eladkal commented on code in PR #50760: URL: https://github.com/apache/airflow/pull/50760#discussion_r2094985272 ## airflow-core/newsfragments/50374.feature.rst: ## Review Comment: I think this is more a bug fix than a feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default 'once' start_date to 'now' when None [airflow]
Lee-W commented on code in PR #50760: URL: https://github.com/apache/airflow/pull/50760#discussion_r2095346121 ## airflow-core/newsfragments/50374.feature.rst: ## Review Comment: Sounds like a feature to me. 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default 'once' start_date to 'now' when None [airflow]
eladkal commented on code in PR #50760: URL: https://github.com/apache/airflow/pull/50760#discussion_r2095039062 ## airflow-core/newsfragments/50374.feature.rst: ## Review Comment: To me this was un intentional behavior change between 2->3. Not something we planned explicitly so at least from my point of view we are fixing something that did not really work as we intended (or did I miss something in the Slack thread?) but if we consider this a feature then we need to tag this PR for 3.1 not for 3.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default 'once' start_date to 'now' when None [airflow]
eladkal commented on code in PR #50760: URL: https://github.com/apache/airflow/pull/50760#discussion_r2095039062 ## airflow-core/newsfragments/50374.feature.rst: ## Review Comment: To me this was un intentional behavior change between 2->3. Not something we planned explicitly so at least from my point of view we are fixing something that did not really work as we intended but if we consider this a feature then we need to tag this PR for 3.1 not for 3.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default 'once' start_date to 'now' when None [airflow]
uranusjr commented on code in PR #50760: URL: https://github.com/apache/airflow/pull/50760#discussion_r2095023464 ## airflow-core/newsfragments/50374.feature.rst: ## Review Comment: I wouldn’t say it’s a bug, Airflow is doing what you tell it to. In all other timetables, `start_date=None` means the dag would never run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
