Re: [PR] Deprecating email, email_on_retry, email_on_failure in BaseOperator [airflow]
eladkal merged PR #47146: URL: https://github.com/apache/airflow/pull/47146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in BaseOperator [airflow]
eladkal commented on code in PR #47146: URL: https://github.com/apache/airflow/pull/47146#discussion_r1974171105 ## task_sdk/src/airflow/sdk/definitions/baseoperator.py: ## @@ -956,6 +957,25 @@ def __init__( self.email_on_retry = email_on_retry self.email_on_failure = email_on_failure +if email is not None: +warnings.warn( +"email is deprecated please migrate to SmtpNotifier`.", +RemovedInAirflow4Warning, +stacklevel=2, +) +if email and email_on_retry is not None: Review Comment: We must have it because `email_on_retry` has default True and we don't want to change the default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in BaseOperator [airflow]
ferruzzi commented on code in PR #47146: URL: https://github.com/apache/airflow/pull/47146#discussion_r1974109353 ## task_sdk/src/airflow/sdk/definitions/baseoperator.py: ## @@ -956,6 +957,25 @@ def __init__( self.email_on_retry = email_on_retry self.email_on_failure = email_on_failure +if email is not None: +warnings.warn( +"email is deprecated please migrate to SmtpNotifier`.", +RemovedInAirflow4Warning, +stacklevel=2, +) +if email and email_on_retry is not None: Review Comment: Here and the next block, I think you should drop the check for `email`, it's not really relevant. If they use `email_on_retry` or `email_on_failure` they should get the notice, we don't really care if `email` is set or not at that point, do we? Otherwise LGTM assuming the CI finishes green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
eladkal closed pull request #45705: Deprecating email, email_on_retry, email_on_failure in `BaseOperator` URL: https://github.com/apache/airflow/pull/45705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
eladkal commented on PR #45705: URL: https://github.com/apache/airflow/pull/45705#issuecomment-2687976656 Closed in favor of https://github.com/apache/airflow/pull/47146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
eladkal commented on PR #45705: URL: https://github.com/apache/airflow/pull/45705#issuecomment-2609669963 > @eladkal I think we need to add `ignore::RemovedInAirflow3Warning` in [pyproject.py](https://github.com/apache/airflow/blob/f01c53a73573a5dacb2107944d32a5fd731d64f6/pyproject.toml#L468) for the tests to pass. We can't because of https://github.com/apache/airflow/blob/f01c53a73573a5dacb2107944d32a5fd731d64f6/pyproject.toml#L492-L499 The issue is `RemovedInAirflow3Warning` already there yet tests are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
utkarsharma2 commented on PR #45705: URL: https://github.com/apache/airflow/pull/45705#issuecomment-2609408727 @eladkal I think we need to add `ignore::RemovedInAirflow3Warning` in [pyproject.py](https://github.com/apache/airflow/blob/f01c53a73573a5dacb2107944d32a5fd731d64f6/pyproject.toml#L468) for the tests to pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
eladkal commented on PR #45705: URL: https://github.com/apache/airflow/pull/45705#issuecomment-2603837850 > Not specific to this PR, are patches to v2-10-test at this point going into a 2.10 patch release, or 2.11.0? Depends on what if we decide to do 2.11 - I think this was not yet decided in the last dev call. Regardless 2.11 branch will be cut from 2.10 branch so from PRs point of view it's the same process for merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
uranusjr commented on PR #45705: URL: https://github.com/apache/airflow/pull/45705#issuecomment-2603832863 Not specific to this PR, are patches to v2-10-test at this point going into a 2.10 patch release, or 2.11.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
