Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
geraj1010 commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2510200587 > > Greetings, I was away for the holidays. Thank you all for review! > > @kaxil Thank you for resolving the conflict. Can you please tell me what it was? > > Hi @geraj1010 , I hope you had a good holiday. Your base branch was 1000 commits behind the Airflow main -- Example: https://github.com/apache/airflow/commits/39ebd75c5cb066218a2b6b3940eddc217dd816d9/docs/sphinx_design/static/custom.css -- your branch's base commit was from December 2023 -- so rebased on the main branch. > > https://private-user-images.githubusercontent.com/8811558/391329333-dccf8aef-d95b-4c93-aa43-6aed31160571.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzMwNzgzNTUsIm5iZiI6MTczMzA3ODA1NSwicGF0aCI6Ii84ODExNTU4LzM5MTMyOTMzMy1kY2NmOGFlZi1kOTViLTRjOTMtYWE0My02YWVkMzExNjA1NzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTIwMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEyMDFUMTgzNDE1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWY2MjNlZjc3MmU3OTcyNWQ0YzFjNTZkYzhkZjk3ZjRkZmI0NGI3YmQ4M2MxMmY3NDk5NjRmZWFkMjFkZTFhZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.WwJCbyPFWRKXSDs5c4y-bZoEcPw8GEEvPoaYaqbXMMM";> Ahh I see! I wonder how that happened? I've only started contributing in August 2024. Maybe I forked the repo incorrectly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
kaxil commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2509731479 > Greetings, I was away for the holidays. Thank you all for review! > > @kaxil Thank you for resolving the conflict. Can you please tell me what it was? Hi @geraj1010 , I hope you had a good holiday. Your base branch was 1000 commits behind the Airflow main -- Example: https://github.com/apache/airflow/commits/39ebd75c5cb066218a2b6b3940eddc217dd816d9/docs/sphinx_design/static/custom.css -- your branch's base commit was from December 2023 -- so rebased on the main branch. https://github.com/user-attachments/assets/dccf8aef-d95b-4c93-aa43-6aed31160571";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
geraj1010 commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2509545502 Greetings, I was away for the holidays. Thank you all for review! @kaxil Thank you for resolving the conflict. Can you please tell me what it was? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
geraj1010 commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2509544808 > Thanks a lot for looking into this @kaxil, and kudos @geraj1010 for this PR! > > I've raised #44479 to use the warning block wherever applicable, so that we can show these prominent deprecation warnings consistently across Airflow docs. Cheers. My pleasure! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
omkar-foss commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2507932277 Thanks a lot for looking into this @kaxil, and kudos @geraj1010 for this PR! I've raised https://github.com/apache/airflow/pull/44479 to use the warning block wherever applicable, so that we can show these prominent deprecation warnings consistently across Airflow docs. Cheers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
kaxil commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2506899335 @eladkal Worth including this change in the next batch of providers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
kaxil commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2506898544 Verified it locally: https://github.com/user-attachments/assets/bb02a45f-2f6b-438f-af36-355fb20aef90";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
kaxil commented on PR #43909: URL: https://github.com/apache/airflow/pull/43909#issuecomment-2506898334 I resolved the conflict, and merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Docs: Add prominent deprecations notice via css [airflow]
kaxil merged PR #43909: URL: https://github.com/apache/airflow/pull/43909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
