Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
shahar1 commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3901260388 > @shahar1 - This PR introduced a bug that breaks EKS operators. #61891 should be the fix. Any chance you can squeeze that one in still so we don't push broken code? Sure, thanks for testing - I'll exclude it from upcoming release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
ferruzzi commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3900062904 @shahar1 - This PR introduced a bug that breaks EKS operators. https://github.com/apache/airflow/pull/61891 should be the fix. Any chance you can squeeze that one in still so we don't push broken code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
boring-cyborg[bot] commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3879461243 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
shahar1 merged PR #61441: URL: https://github.com/apache/airflow/pull/61441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
shahar1 commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3879433552 > > @idrisakorede please do not merge from main and let the CI run without interruptions, otherwise I need to re-approve and rerun it each time. I want to start working on the release in an hour or so, so it's important if you want this PR to be included there :) Thank you! > > @shahar1 Understood! I apologize for the interruptions, I’ll stop clicking the update button and let the CI run completely. I didn’t realize each update was restarting the process. Looking forward to seeing this included in the release. Thank you for your patience and guidance! No problem at all! it's almost done and ready to go :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
idrisakorede commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3879346484 > @idrisakorede please do not merge from main and let the CI run without interruptions, otherwise I need to re-approve and rerun it each time. I want to start working on the release in an hour or so, so it's important if you want this PR to be included there :) Thank you! Understood! I apologize for the interruptions, I’ll stop clicking the update button and let the CI run completely. I didn’t realize each update was restarting the process. Looking forward to seeing this included in the release. Thank you for your patience and guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
shahar1 commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3879135024 @idrisakorede please do not merge from main and let the CI run without interruptions, otherwise I need to re-approve and rerun it each time. I want to start working on the release in an hour or so, so it's important if you want this PR to be included :) Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
idrisakorede commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3879086524 > should we use `v1` instead of `v1beta1`? i actually thought of this, but just felt i should make the changes based on what was in the script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
shahar1 commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3878931021 > > > should we use `v1` instead of `v1beta1`? > > > > > > Good call! I think we should, I updated the reference and updated the PR's title (as it might be even more important than just the POSIX). If during the RC1 tests we'll see a regression because of that, we could postpone the release. > > oops, missed the unit test You got me, thanks! Trying again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
andrewhharmon commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3878808823 > > should we use `v1` instead of `v1beta1`? > > Good call! I think we should, I updated the reference and updated the PR's title (as it might be even more important than just the POSIX). If during the RC1 tests we'll see a regression because of that, we could postpone the release. oops, missed the unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] EKS hook: Update auth. API version to v1 and replace non-POSIX 'source' with '.' [airflow]
shahar1 commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3878576045 > should we use `v1` instead of `v1beta1`? Good call! I think we should, I updated the reference and updated the PR's title. If during the RC1 tests we'll see a regression because of that, we could postpone the release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
