Re: [PR] Fix: Delete Kubernetes jobs if they are killed in the UI [airflow]

2024-12-11 Thread via GitHub


hhhonzik commented on PR #43938:
URL: https://github.com/apache/airflow/pull/43938#issuecomment-2535956288

   I've seen a lot of issues with JobOperator, possibly thanks to this change - 
duplicated pod / job generators etc. 
   
   With the update by @eladkal PodOperator seems to be working for us. Closing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix: Delete Kubernetes jobs if they are killed in the UI [airflow]

2024-12-11 Thread via GitHub


hhhonzik closed pull request #43938: Fix: Delete Kubernetes jobs if they are 
killed in the UI
URL: https://github.com/apache/airflow/pull/43938


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix: Delete Kubernetes jobs if they are killed in the UI [airflow]

2024-11-20 Thread via GitHub


eladkal commented on PR #43938:
URL: https://github.com/apache/airflow/pull/43938#issuecomment-2488475367

   can we have unit test to cover this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix: Delete Kubernetes jobs if they are killed in the UI [airflow]

2024-11-18 Thread via GitHub


romsharon98 commented on code in PR #43938:
URL: https://github.com/apache/airflow/pull/43938#discussion_r1847703975


##
providers/src/airflow/providers/cncf/kubernetes/operators/job.py:
##
@@ -273,7 +273,6 @@ def on_kill(self) -> None:
 kwargs = {
 "name": job.metadata.name,
 "namespace": job.metadata.namespace,
-"job": 
self.hook.batch_v1_client.api_client.sanitize_for_serialization(self.job),

Review Comment:
   removed in this PR https://github.com/apache/airflow/pull/44131, try to 
rebase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix: Delete Kubernetes jobs if they are killed in the UI [airflow]

2024-11-18 Thread via GitHub


romsharon98 commented on code in PR #43938:
URL: https://github.com/apache/airflow/pull/43938#discussion_r1847703975


##
providers/src/airflow/providers/cncf/kubernetes/operators/job.py:
##
@@ -273,7 +273,6 @@ def on_kill(self) -> None:
 kwargs = {
 "name": job.metadata.name,
 "namespace": job.metadata.namespace,
-"job": 
self.hook.batch_v1_client.api_client.sanitize_for_serialization(self.job),

Review Comment:
   removed in this PR 
   https://github.com/apache/airflow/pull/44131



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix: Delete Kubernetes jobs if they are killed in the UI [airflow]

2024-11-12 Thread via GitHub


hhhonzik commented on code in PR #43938:
URL: https://github.com/apache/airflow/pull/43938#discussion_r1838373975


##
providers/src/airflow/providers/cncf/kubernetes/operators/job.py:
##
@@ -273,7 +273,6 @@ def on_kill(self) -> None:
 kwargs = {
 "name": job.metadata.name,
 "namespace": job.metadata.namespace,
-"job": 
self.hook.batch_v1_client.api_client.sanitize_for_serialization(self.job),

Review Comment:
   there is no `job` argument:
   
   
https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/BatchV1Api.md#parameters-5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org