Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
andrewhharmon commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3878005285 should we use `v1` instead of `v1beta1`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
idrisakorede commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3870068639 > Some tests are failing, they need to be updated. It should be fairly easy My bad, i am somewhat relatively new to open source, so i didn't go through the existing test script thoroughly to check if there's a test that checks for the changes i made. With what you said about my tests being excessive should have been a cue to that effect, but i was slow to understanding what you truly mean. I have updated the tests, so all should be good now. Thanks for the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
vincbeck commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3854396917 Some tests are failing, they need to be updated. It should be fairly easy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
idrisakorede commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3849479661 > I dont think I talk to a human but the code looks good Thanks. But i don't get the human reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
vincbeck commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3849224063 I dont think I talk to a human but the code looks good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
idrisakorede commented on code in PR #61441: URL: https://github.com/apache/airflow/pull/61441#discussion_r2765247572 ## providers/amazon/tests/unit/amazon/aws/hooks/test_eks.py: ## @@ -1318,3 +1320,68 @@ def assert_is_valid_uri(value: str) -> None: assert all([result.scheme, result.netloc, result.path]) assert REGION in value + + +class TestEksHookShellCompatibility: Review Comment: @vincbeck You're right! I've simplified the tests to just one assertion that verifies we're using the POSIX-compliant dot operator instead of 'source'. This should be sufficient to prevent regression while keeping the test suite lean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
vincbeck commented on code in PR #61441: URL: https://github.com/apache/airflow/pull/61441#discussion_r2764607095 ## providers/amazon/tests/unit/amazon/aws/hooks/test_eks.py: ## @@ -1318,3 +1320,68 @@ def assert_is_valid_uri(value: str) -> None: assert all([result.scheme, result.netloc, result.path]) assert REGION in value + + +class TestEksHookShellCompatibility: Review Comment: I find these tests too much for the change. Can you reduce the tests to one (or even 0 test for change would make sense to me) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix #60269: Replace non-POSIX 'source' with '.' in EKS hook [airflow]
boring-cyborg[bot] commented on PR #61441: URL: https://github.com/apache/airflow/pull/61441#issuecomment-3846453471 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
