Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
boring-cyborg[bot] commented on PR #58704: URL: https://github.com/apache/airflow/pull/58704#issuecomment-3675268778 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
ephraimbuddy merged PR #58704: URL: https://github.com/apache/airflow/pull/58704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
ephraimbuddy commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2631930435 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2588,6 +2509,17 @@ dag_processor: type: integer example: ~ default: "30" +health_check_threshold: Review Comment: @uranusjr I suggested we don't follow the existing pattern [here](https://github.com/apache/airflow/pull/58704#discussion_r2619641652). it's actually odd that we have to do : AIRFLOW__DAG_PROCESSOR__DAG_PROCESSOR_HEALTH_CHECK_THRESHOLD. WDYT I don't have strong opinion here, so if adding dag_processor is preferred, ok with me too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2629786236 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2588,6 +2509,17 @@ dag_processor: type: integer example: ~ default: "30" +health_check_threshold: Review Comment: Thanks for reviewing it, it was following the existing pattern , but look at @ephraimbuddy comments above. I changed the code to remove the prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
uranusjr commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2629776222 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2588,6 +2509,17 @@ dag_processor: type: integer example: ~ default: "30" +health_check_threshold: Review Comment: Should this be called `dag_processor_health_check_threshold` to match existing pattern? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2629632960 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,17 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: Review Comment: addressed comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2620230790 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,17 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: Review Comment: Thank you for the review @ephraimbuddy , I will address it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
ephraimbuddy commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2619641652 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,17 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: Review Comment: ```suggestion health_check_threshold: ``` This is already under the dag_processor section. I guess you want it to align with scheduler /triggerer but I think it's ok to have it as health_check_threshold only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
coenvd commented on PR #58704: URL: https://github.com/apache/airflow/pull/58704#issuecomment-3654362196 Any chance that someone else can review this as well? @vbottu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on PR #58704: URL: https://github.com/apache/airflow/pull/58704#issuecomment-3621568920 @ephraimbuddy, @choo121600 ,@potiuk , Could you please review it when you get a chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on PR #58704: URL: https://github.com/apache/airflow/pull/58704#issuecomment-3585607070 @coenvd ,Thanks for the note. To clarify: the /health referenced in the config description is the webserver’s health endpoint (/api/v2/monitor/health), which reports DAG processor status based on its job heartbeat. The standalone DAG processor itself doesn’t expose an HTTP /health, so not seeing one on that pod is expected. The /health you’re observing in the scheduler pod is from the scheduler’s own health-check server. I can update the wording in the config to make this distinction clearer if that helps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
coenvd commented on PR #58704: URL: https://github.com/apache/airflow/pull/58704#issuecomment-3584767020 @vbottu I see in `airflow-core/src/airflow/config_templates/config.yml` that you mention a `/health` endpoint that to me seems to refer to a `/health` endpoint inside the DAG processor. I checked the exposed ports inside my DAG processor pod, and cannot find a health endpoint being exposed. If I do the same in the scheduler pod, I do see the endpoint. Is this a misinterpretation on my end, a skill issue on my end, or is the health endpoint in the standalone DAG processor pod really not available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
choo121600 commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2567303941 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,16 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: + description: | +If the last dag processor heartbeat happened more than ``[dag_processor] dag_processor_health_check_threshold`` +ago (in seconds), dag processor is considered unhealthy. +This is used by the health check in the **/health** endpoint and in ``airflow jobs check`` CLI +for DagProcessorJob. Review Comment: Good ;0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2565879992 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,16 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: + description: | +If the last dag processor heartbeat happened more than ``[dag_processor] dag_processor_health_check_threshold`` +ago (in seconds), dag processor is considered unhealthy. +This is used by the health check in the **/health** endpoint and in ``airflow jobs check`` CLI +for DagProcessorJob. Review Comment: I verified and fixed it , the line length needs to be below 110 chars, I adjusted and pushed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
vbottu commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2565766140 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,16 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: + description: | +If the last dag processor heartbeat happened more than ``[dag_processor] dag_processor_health_check_threshold`` +ago (in seconds), dag processor is considered unhealthy. +This is used by the health check in the **/health** endpoint and in ``airflow jobs check`` CLI +for DagProcessorJob. Review Comment: Thank you for the review, let me take a look at it and handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
choo121600 commented on code in PR #58704: URL: https://github.com/apache/airflow/pull/58704#discussion_r2564482747 ## airflow-core/src/airflow/config_templates/config.yml: ## @@ -2509,6 +2509,16 @@ dag_processor: type: integer example: ~ default: "30" +dag_processor_health_check_threshold: + description: | +If the last dag processor heartbeat happened more than ``[dag_processor] dag_processor_health_check_threshold`` +ago (in seconds), dag processor is considered unhealthy. +This is used by the health check in the **/health** endpoint and in ``airflow jobs check`` CLI +for DagProcessorJob. Review Comment: It looks like the issue is caused by the description section being too long. If you adjust that part appropriately, it should resolve the problem. 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix DAG Processor health check threshold matching the pattern used by… [airflow]
boring-cyborg[bot] commented on PR #58704: URL: https://github.com/apache/airflow/pull/58704#issuecomment-3579220020 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
