Re: [PR] Fix PythonVirtualenvOperator uv venv creation without internet access [airflow]
potiuk closed pull request #59030: Fix PythonVirtualenvOperator uv venv creation without internet access URL: https://github.com/apache/airflow/pull/59030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix PythonVirtualenvOperator uv venv creation without internet access [airflow]
potiuk commented on PR #59030: URL: https://github.com/apache/airflow/pull/59030#issuecomment-3662805608 Needs rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix PythonVirtualenvOperator uv venv creation without internet access [airflow]
potiuk commented on PR #59030: URL: https://github.com/apache/airflow/pull/59030#issuecomment-3619732323 Let's see what CI says :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix PythonVirtualenvOperator uv venv creation without internet access [airflow]
Arunodoy18 commented on PR #59030: URL: https://github.com/apache/airflow/pull/59030#issuecomment-3610735426 Hi maintainers! 👋 This PR fixes an issue where `PythonVirtualenvOperator` fails in environments without direct internet access when using `uv` for package management. **The Problem:** When `index_urls_from_connection_ids` is configured to use custom package indexes (e.g., Artifactory in transparent proxy mode), the `uv venv --seed` command was still trying to reach `https://pypi.org/simple/pip/` directly, causing timeout errors in air-gapped or restricted network environments. **The Solution:** Pass the `UV_DEFAULT_INDEX` and `UV_INDEX` environment variables during virtual environment creation, matching the behavior already implemented for package installation commands. **Testing:** - Added unit test `test_should_create_virtualenv_with_index_urls_uv` to verify index URLs are passed to both venv creation and package installation - Follows the same pattern already used for `pip_cmd` execution in the codebase This should help users deploying Airflow in secure/enterprise environments with restricted internet access. Happy to address any feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix PythonVirtualenvOperator uv venv creation without internet access [airflow]
boring-cyborg[bot] commented on PR #59030: URL: https://github.com/apache/airflow/pull/59030#issuecomment-3610727812 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
