Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
eladkal merged PR #66682: URL: https://github.com/apache/airflow/pull/66682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
dominikhei commented on PR #66682: URL: https://github.com/apache/airflow/pull/66682#issuecomment-4459094700 LGTM otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
Vamsi-klu commented on code in PR #66682: URL: https://github.com/apache/airflow/pull/66682#discussion_r3245311989 ## providers/tableau/docs/changelog.rst: ## @@ -30,6 +30,11 @@ Changelog 5.4.0 . +Bug Fixes Review Comment: @dominikhei Good catch , dropped the changelog lines in 24d82c9169. The fix will be picked up from git log at the next provider release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
Vamsi-klu commented on code in PR #66682: URL: https://github.com/apache/airflow/pull/66682#discussion_r3245311989 ## providers/tableau/docs/changelog.rst: ## @@ -30,6 +30,11 @@ Changelog 5.4.0 . +Bug Fixes Review Comment: Good catch , dropped the changelog lines in 24d82c9169. The fix will be picked up from git log at the next provider release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
Vamsi-klu commented on code in PR #66682: URL: https://github.com/apache/airflow/pull/66682#discussion_r3245311989 ## providers/tableau/docs/changelog.rst: ## @@ -30,6 +30,11 @@ Changelog 5.4.0 . +Bug Fixes Review Comment: Good catch — dropped the changelog lines in 24d82c9169. The fix will be picked up from git log at the next provider release. --- Drafted-by: Claude Code (Opus 4.7); reviewed by @Vamsi-klu before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
Vamsi-klu commented on code in PR #66682: URL: https://github.com/apache/airflow/pull/66682#discussion_r3242435021 ## providers/tableau/docs/changelog.rst: ## @@ -30,6 +30,11 @@ Changelog 5.4.0 . +Bug Fixes Review Comment: Thanks for the feedback, I'll fix it in couple of days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
dominikhei commented on code in PR #66682: URL: https://github.com/apache/airflow/pull/66682#discussion_r3235701727 ## providers/tableau/docs/changelog.rst: ## @@ -30,6 +30,11 @@ Changelog 5.4.0 . +Bug Fixes Review Comment: 5.4.0 was already cut? So you should remove the lines from the changelog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix TableauOperator tasks.run AttributeError [airflow]
Vamsi-klu commented on PR #66682: URL: https://github.com/apache/airflow/pull/66682#issuecomment-4417290795 Tagging a few people who have recently reviewed or worked on Tableau provider changes and may have useful context here: @potiuk @eladkal @dominikhei. This PR fixes `TableauOperator(resource="tasks", method="run")`, which currently treats `tasks.run()` like other resource methods even though Tableau expects a `TaskItem` input and returns XML bytes instead of an object with `.id`. The change resolves the task first, calls `tasks.run(task_item)`, and parses the returned job payload via `JobItem.from_response`. If you have a moment, I’d appreciate a quick look at the Tableau-specific behavior and whether this response handling matches the expected `tableauserverclient` semantics. --- Drafted-by: Codex GPT-5 (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
