Re: [PR] Fix asset events table title [airflow]

2025-06-12 Thread via GitHub 


pierrejeambrun merged PR #51658:
URL: https://github.com/apache/airflow/pull/51658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] Fix asset events table title [airflow]

2025-06-12 Thread via GitHub 


pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967319137

   Handled in last commit:
   ![Screenshot 2025-06-12 at 17 28 
49](https://github.com/user-attachments/assets/1037687d-b351-4709-9bb9-07dcc082057c)
   ![Screenshot 2025-06-12 at 17 33 
02](https://github.com/user-attachments/assets/d2937d11-825b-448f-8dbc-0c15b4f4695b)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] Fix asset events table title [airflow]

2025-06-12 Thread via GitHub 


pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967235164

   I need to handle the pluralized part though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] Fix asset events table title [airflow]

2025-06-12 Thread via GitHub 


pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967231125

   Edit: It's actually correctly done in `v3-0-test`, we are doing:
   ```js
   {pluralize(title ?? "Asset Event", data?.total_entries ?? 0, undefined, 
true)}
   ```
   
   Removing the backport label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] Fix asset events table title [airflow]

2025-06-12 Thread via GitHub 


pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967226488

   Updated, I'll backport this manually. (basically just use the `title` 
directly without accessing any translation hook)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] Fix asset events table title [airflow]

2025-06-12 Thread via GitHub 


bbovenzi commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967222477

   We can't backport this since it includes translations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]