Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
github-actions[bot] closed pull request #46424: Fix deferrable databricks operator failed before defer URL: https://github.com/apache/airflow/pull/46424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
github-actions[bot] commented on PR #46424: URL: https://github.com/apache/airflow/pull/46424#issuecomment-2846045026 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
eladkal commented on PR #46424: URL: https://github.com/apache/airflow/pull/46424#issuecomment-2728120684 @GabrielSalla are you still working on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
GabrielSalla commented on code in PR #46424:
URL: https://github.com/apache/airflow/pull/46424#discussion_r1961769712
##
providers/src/airflow/providers/databricks/operators/databricks.py:
##
@@ -207,6 +207,12 @@ def
_handle_deferrable_databricks_operator_execution(operator, hook, log, contex
else:
if run_state.is_successful:
log.info("%s completed successfully.", operator.task_id)
+else:
+error_message = (
+f"{operator.task_id} failed with terminal state:
{run_state} "
+f"and with the error {run_state.state_message}"
+)
+raise AirflowException(error_message)
Review Comment:
I'll take a look at how other operators handles this kind of exceptions to
make it similar for these operators, while also fixing the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
Lee-W commented on code in PR #46424:
URL: https://github.com/apache/airflow/pull/46424#discussion_r1961159789
##
providers/src/airflow/providers/databricks/operators/databricks.py:
##
@@ -207,6 +207,12 @@ def
_handle_deferrable_databricks_operator_execution(operator, hook, log, contex
else:
if run_state.is_successful:
log.info("%s completed successfully.", operator.task_id)
+else:
+error_message = (
+f"{operator.task_id} failed with terminal state:
{run_state} "
+f"and with the error {run_state.state_message}"
+)
+raise AirflowException(error_message)
Review Comment:
I'm not sure whether we should use `AirflowExecption` here 🤔 (it's a vague
exception) , but if we want to change it, we probably will need to change the
one in _handle_databricks_operator_execution as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
potiuk commented on PR #46424: URL: https://github.com/apache/airflow/pull/46424#issuecomment-2637771406 @alexott ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
GabrielSalla closed pull request #46311: Fix deferrable databricks operator failed before defer URL: https://github.com/apache/airflow/pull/46311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
GabrielSalla commented on PR #46311: URL: https://github.com/apache/airflow/pull/46311#issuecomment-2627440012 I missed one test in the previous commit, just fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix deferrable databricks operator failed before defer [airflow]
boring-cyborg[bot] commented on PR #46311: URL: https://github.com/apache/airflow/pull/46311#issuecomment-2627298794 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
