Re: [PR] Fix empty task instance for log [airflow]
github-actions[bot] commented on PR #45702: URL: https://github.com/apache/airflow/pull/45702#issuecomment-2594875779 ### Backport failed to create: v2-10-test. View the failure log Run details Status Branch Result ❌ v2-10-test https://github.com/apache/airflow/commit/e8f55b3a3d4e45285c6f11099794ddceb6ea4491";> You can attempt to backport this manually by running: ```bash cherry_picker e8f55b3 v2-10-test ``` This should apply the commit to the v2-10-test branch and leave the commit in conflict state marking the files that need manual conflict resolution. After you have resolved the conflicts, you can continue the backport process by running: ```bash cherry_picker --continue ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
boring-cyborg[bot] commented on PR #45702: URL: https://github.com/apache/airflow/pull/45702#issuecomment-2594872649 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
jscheffl merged PR #45702: URL: https://github.com/apache/airflow/pull/45702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
MishchenkoYuriy commented on code in PR #45702: URL: https://github.com/apache/airflow/pull/45702#discussion_r1917998079 ## airflow/www/views.py: ## @@ -1774,7 +1774,7 @@ def log(self, session: Session = NEW_SESSION): title="Log by attempts", dag_id=dag_id, task_id=task_id, -task_display_name=ti.task_display_name, +task_display_name=ti.task_display_name if ti else "", Review Comment: We're running 2.10.3, I'm not sure how it occurred to be honest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
jscheffl commented on code in PR #45702: URL: https://github.com/apache/airflow/pull/45702#discussion_r1917975232 ## airflow/www/views.py: ## @@ -1774,7 +1774,7 @@ def log(self, session: Session = NEW_SESSION): title="Log by attempts", dag_id=dag_id, task_id=task_id, -task_display_name=ti.task_display_name, +task_display_name=ti.task_display_name if ti else "", Review Comment: Thanks! Bug ticket not needed - just wanted to understand the context. Back-port to 2.10-line would be something that I would take care of. Nothing you need to to. Mainly wanted to know if the error is from Airflow 2.10... or which version you are running? Can you describe where and how the error was produced? Which link did you click? Is a specific DAG needed? Just want to understand for proper qualification. And forgot to say: Thanks for the contribution and implicit improvement/reporting the issue! That is all appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
MishchenkoYuriy commented on code in PR #45702: URL: https://github.com/apache/airflow/pull/45702#discussion_r1917929503 ## airflow/www/views.py: ## @@ -1774,7 +1774,7 @@ def log(self, session: Session = NEW_SESSION): title="Log by attempts", dag_id=dag_id, task_id=task_id, -task_display_name=ti.task_display_name, +task_display_name=ti.task_display_name if ti else "", Review Comment: Error: https://github.com/user-attachments/assets/b6ebf1b8-3e2a-4424-b882-b2012a1a67b2"; /> On the line 1773 you do the same https://github.com/apache/airflow/blob/03d5ba16ca63b157311d95557263dcfc7079f9c7/airflow/www/views.py#L1773 As far as I know, there isn't a bug ticket. > Does it need to be back-ported to Airflow 2.10-line? I don't have an opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
MishchenkoYuriy commented on code in PR #45702: URL: https://github.com/apache/airflow/pull/45702#discussion_r1917929503 ## airflow/www/views.py: ## @@ -1774,7 +1774,7 @@ def log(self, session: Session = NEW_SESSION): title="Log by attempts", dag_id=dag_id, task_id=task_id, -task_display_name=ti.task_display_name, +task_display_name=ti.task_display_name if ti else "", Review Comment: Error: https://github.com/user-attachments/assets/b6ebf1b8-3e2a-4424-b882-b2012a1a67b2"; /> On the line 1773 you do the same https://github.com/apache/airflow/blob/03d5ba16ca63b157311d95557263dcfc7079f9c7/airflow/www/views.py#L1773 As far as I know, there isn't a bug ticket. > Does it need to be back-ported to Airflow 2.10-line? I don't have an opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
jscheffl commented on code in PR #45702: URL: https://github.com/apache/airflow/pull/45702#discussion_r1917916842 ## airflow/www/views.py: ## @@ -1774,7 +1774,7 @@ def log(self, session: Session = NEW_SESSION): title="Log by attempts", dag_id=dag_id, task_id=task_id, -task_display_name=ti.task_display_name, +task_display_name=ti.task_display_name if ti else "", Review Comment: If there is no task_display_name then the task_id should be the fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix empty task instance for log [airflow]
boring-cyborg[bot] commented on PR #45702: URL: https://github.com/apache/airflow/pull/45702#issuecomment-2594759664 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points: - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices). - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
