Re: [PR] Fix gantt chart rendering issues [airflow]
bbovenzi merged PR #4: URL: https://github.com/apache/airflow/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix gantt chart rendering issues [airflow]
bbovenzi commented on code in PR #4:
URL: https://github.com/apache/airflow/pull/4#discussion_r2344583208
##
airflow-core/src/airflow/ui/src/layouts/Details/Gantt/Gantt.tsx:
##
@@ -120,6 +125,20 @@ export const Gantt = ({ limit }: Props) => {
},
);
+ // Get task instance try details
+ const { data: selectedTaskInstanceTry } =
useTaskInstanceServiceGetTaskInstanceTryDetails(
+{
+ dagId,
+ dagRunId: runId,
+ taskId: selectedTaskId ?? "",
+ taskTryNumber: parseInt(tryNumber ?? "-1", 10),
+},
+undefined,
+{
+ enabled: Boolean(tryNumber) && tryNumber !== "-1",
+},
+ );
Review Comment:
Oh actually, we should be showing every single task try at once in the gantt
chart! I forgot about that feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Fix gantt chart rendering issues [airflow]
bbovenzi commented on PR #4: URL: https://github.com/apache/airflow/pull/4#issuecomment-3286416457 > Just to confirm, should every single task tries be displayed in the same row? Yes exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Fix gantt chart rendering issues [airflow]
guan404ming commented on PR #4: URL: https://github.com/apache/airflow/pull/4#issuecomment-3285728869 > Animation and date range look good to me. Let's do task tries in another PR since we need to do more work there. Sure, I've removed the task tries related code. > Oh actually, we should be showing every single task try at once in the gantt chart! I forgot about that feature. Just to confirm, should every single task tries be displayed in the same row? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
