Re: [PR] Helm: generate jwt-secret on installation only [airflow]
github-actions[bot] closed pull request #57415: Helm: generate jwt-secret on installation only URL: https://github.com/apache/airflow/pull/57415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Helm: generate jwt-secret on installation only [airflow]
github-actions[bot] commented on PR #57415: URL: https://github.com/apache/airflow/pull/57415#issuecomment-4017735316 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Helm: generate jwt-secret on installation only [airflow]
arkadiuszbach commented on PR #57415: URL: https://github.com/apache/airflow/pull/57415#issuecomment-3773414275 > It was done this way in #51799 so updates from Airflow 2 to Airflow 3 work. And it's best practice to set this explicitly which avoids the problem completely. I was using 1.18.0 helm chart, it was not there yet from what i can see, but even if it is restarted: - before all instances are restarted we may get random failures i think - what about worker, it may have tasks running for 1hour so it wont be able to restart, api servers will have new jwt but worker will still use the old one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Helm: generate jwt-secret on installation only [airflow]
jedcunningham commented on PR #57415: URL: https://github.com/apache/airflow/pull/57415#issuecomment-3740125402 [These checksums](https://github.com/apache/airflow/blob/b62ca705ec7af590e4a099fdadf99de286714240/chart/templates/api-server/api-server-deployment.yaml#L91) don't force restarts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Helm: generate jwt-secret on installation only [airflow]
jedcunningham commented on code in PR #57415:
URL: https://github.com/apache/airflow/pull/57415#discussion_r2683566067
##
chart/templates/secrets/jwt-secret.yaml:
##
@@ -35,10 +35,13 @@ metadata:
{{- with .Values.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
- {{- with .Values.jwtSecretAnnotations }}
annotations:
+"helm.sh/hook": "pre-install"
+"helm.sh/hook-delete-policy": "before-hook-creation"
+"helm.sh/hook-weight": "0"
Review Comment:
I don't recall exactly why, but I have in my mind that there is some
funkiness with helm lookup that makes it not great for our needs. But maybe in
some of these cases, it's better than nothing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Helm: generate jwt-secret on installation only [airflow]
Miretpl commented on code in PR #57415:
URL: https://github.com/apache/airflow/pull/57415#discussion_r2678639884
##
chart/templates/secrets/jwt-secret.yaml:
##
@@ -35,10 +35,13 @@ metadata:
{{- with .Values.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
- {{- with .Values.jwtSecretAnnotations }}
annotations:
+"helm.sh/hook": "pre-install"
+"helm.sh/hook-delete-policy": "before-hook-creation"
+"helm.sh/hook-weight": "0"
Review Comment:
After some time I think that we could go with the Helm lookup function to
determine if it exists or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Helm: generate jwt-secret on installation only [airflow]
github-actions[bot] commented on PR #57415: URL: https://github.com/apache/airflow/pull/57415#issuecomment-3731118682 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
