Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
eladkal merged PR #45954: URL: https://github.com/apache/airflow/pull/45954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
boring-cyborg[bot] commented on PR #45954: URL: https://github.com/apache/airflow/pull/45954#issuecomment-2614296649 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
eladkal commented on PR #45954: URL: https://github.com/apache/airflow/pull/45954#issuecomment-2614218664 Still failing See https://github.com/apache/airflow/actions/runs/12970501835/job/36178118560?pr=45954#step:6:8502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
kanagaraj-dhanapal-89 commented on PR #45954: URL: https://github.com/apache/airflow/pull/45954#issuecomment-2613702771 > > Tests are failing > > ``` > > FAILED providers/tests/salesforce/hooks/test_salesforce.py::TestSalesforceHook::test_get_conn_default_to_none - AssertionError: expected call not found. > > Expected: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, privatekey_file=None, privatekey=None) > > Actual: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, consumer_secret=None, privatekey_file=None, privatekey=None) > > ``` > > checking I hope its fixed now, could you please check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
kanagaraj-dhanapal-89 commented on PR #45954: URL: https://github.com/apache/airflow/pull/45954#issuecomment-2611764020 > Tests are failing > > ``` > FAILED providers/tests/salesforce/hooks/test_salesforce.py::TestSalesforceHook::test_get_conn_default_to_none - AssertionError: expected call not found. > Expected: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, privatekey_file=None, privatekey=None) > Actual: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, consumer_secret=None, privatekey_file=None, privatekey=None) > ``` checking -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
eladkal commented on PR #45954: URL: https://github.com/apache/airflow/pull/45954#issuecomment-2611718343 Tests are failing ``` FAILED providers/tests/salesforce/hooks/test_salesforce.py::TestSalesforceHook::test_get_conn_default_to_none - AssertionError: expected call not found. Expected: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, privatekey_file=None, privatekey=None) Actual: Salesforce(username=None, *** security_token=None, domain=None, session_id=None, instance=None, instance_url=None, organizationId=None, version='59.0', proxies=None, session=None, client_id=None, consumer_key=None, consumer_secret=None, privatekey_file=None, privatekey=None) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
kanagaraj-dhanapal-89 commented on PR #45954: URL: https://github.com/apache/airflow/pull/45954#issuecomment-2611533173 > Please ammend the commit and PR title with meeaningful description Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
kanagaraj-dhanapal-89 commented on code in PR #45954: URL: https://github.com/apache/airflow/pull/45954#discussion_r1927519334 ## providers/src/airflow/providers/salesforce/hooks/salesforce.py: ## @@ -151,6 +151,7 @@ def conn(self) -> api.Salesforce: session=self.session, client_id=self._get_field(extras, "client_id") or None, consumer_key=self._get_field(extras, "consumer_key") or None, +consumer_secret=self._get_field(extras, "consumer_secret") or None, Review Comment: updated the test case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
eladkal commented on code in PR #45954: URL: https://github.com/apache/airflow/pull/45954#discussion_r1927369446 ## providers/src/airflow/providers/salesforce/hooks/salesforce.py: ## @@ -151,6 +151,7 @@ def conn(self) -> api.Salesforce: session=self.session, client_id=self._get_field(extras, "client_id") or None, consumer_key=self._get_field(extras, "consumer_key") or None, +consumer_secret=self._get_field(extras, "consumer_secret") or None, Review Comment: ah we need also test coverage. Probably easiest is jus to update `test_get_conn_jwt_auth` https://github.com/eladkal/airflow/blob/857ca4c06c9008593674cabdd28d3c30e3e7f97b/providers/tests/salesforce/hooks/test_salesforce.py#L155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Implement fetching consumer_secret from Salesforce connection [airflow]
eladkal commented on code in PR #45954: URL: https://github.com/apache/airflow/pull/45954#discussion_r1927369446 ## providers/src/airflow/providers/salesforce/hooks/salesforce.py: ## @@ -151,6 +151,7 @@ def conn(self) -> api.Salesforce: session=self.session, client_id=self._get_field(extras, "client_id") or None, consumer_key=self._get_field(extras, "consumer_key") or None, +consumer_secret=self._get_field(extras, "consumer_secret") or None, Review Comment: ah we need also test coverage. Probably easiest is jus to update `test_get_conn_jwt_auth` https://github.com/apache/airflow/blob/857ca4c06c9008593674cabdd28d3c30e3e7f97b/providers/tests/salesforce/hooks/test_salesforce.py#L155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
