Re: [PR] Improve XCom table [airflow]
tirkarthi commented on code in PR #48189:
URL: https://github.com/apache/airflow/pull/48189#discussion_r2010371997
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -34,6 +36,49 @@ const columns: Array> = [
enableSorting: false,
header: "Key",
},
+ {
+accessorKey: "dag_id",
Review Comment:
Sorry, I meant on the basis of them defined in the URL like how it's in the
linked events page implementation.
```js
const { dagId, runId, taskId } = useParams();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Improve XCom table [airflow]
pierrejeambrun commented on code in PR #48189:
URL: https://github.com/apache/airflow/pull/48189#discussion_r2010241604
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -34,6 +36,49 @@ const columns: Array> = [
enableSorting: false,
header: "Key",
},
+ {
+accessorKey: "dag_id",
Review Comment:
dag_id, run_id, and task_id are always defined.
```
class XComResponse(BaseModel):
"""Serializer for a xcom item."""
key: str
timestamp: datetime
logical_date: datetime | None
map_index: int
task_id: str
dag_id: str
run_id: str
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Improve XCom table [airflow]
pierrejeambrun commented on code in PR #48189:
URL: https://github.com/apache/airflow/pull/48189#discussion_r2010241604
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -34,6 +36,49 @@ const columns: Array> = [
enableSorting: false,
header: "Key",
},
+ {
+accessorKey: "dag_id",
Review Comment:
dag_id, run_id, and task_id are always defined. (which is not the case for
the Event datamodel). We don't need to handle null case here.
```
class XComResponse(BaseModel):
"""Serializer for a xcom item."""
key: str
timestamp: datetime
logical_date: datetime | None
map_index: int
task_id: str
dag_id: str
run_id: str
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Improve XCom table [airflow]
pierrejeambrun merged PR #48189: URL: https://github.com/apache/airflow/pull/48189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve XCom table [airflow]
tirkarthi commented on code in PR #48189:
URL: https://github.com/apache/airflow/pull/48189#discussion_r2010069308
##
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##
@@ -34,6 +36,49 @@ const columns: Array> = [
enableSorting: false,
header: "Key",
},
+ {
+accessorKey: "dag_id",
Review Comment:
Can dag_id, run_id and task_id be hidden similar to how they are not
rendered in events page?
https://github.com/apache/airflow/blob/6a703dd1f795784e446742dddf412b0fe3b4e4a0/airflow-core/src/airflow/ui/src/pages/Events/Events.tsx#L44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Improve XCom table [airflow]
tirkarthi commented on PR #48189: URL: https://github.com/apache/airflow/pull/48189#issuecomment-2747925029 Related issue https://github.com/apache/airflow/issues/48003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Improve XCom table [airflow]
pierrejeambrun commented on code in PR #48189:
URL: https://github.com/apache/airflow/pull/48189#discussion_r2009956263
##
airflow-core/src/airflow/ui/src/components/TruncatedText.tsx:
##
@@ -31,7 +31,6 @@ export const TruncatedText = ({ text, ...rest }: Props) => (
WebkitLineClamp: 2,
}}
title={text}
-width="200px"
Review Comment:
This is to not impose a fixed with. If the text can expand, it will, if it
cannot it will wrap and then ellipse:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
