Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
nailo2c commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2646091535 Yes, I'm working on that. I hope I won't encounter the same issue in the next PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
eladkal commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2646088366 Ah cool. Will you raise PR for the other peoviders listed in the issue that were not yet handled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
nailo2c commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2646010719 Hi @eladkal, I've noticed that my code change is included in this [[PR](https://github.com/apache/airflow/pull/46372)](https://github.com/apache/airflow/pull/46372) (check the files changed in the `oracle/`, `presto/`, `vertica/`, and `odbc/` folders). Should I resubmit the original PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
eladkal commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2645949284 @nailo2c can you resubmit the PR and we will look into what was the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
nailo2c commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2631761149 Hi, thanks for reverting. Let me check what happened later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
jscheffl commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2630430311 It seems/smells like this PR broke main. Docs build fails now in https://github.com/apache/airflow/actions/runs/13109792195/job/36571965268 Can this be fixed short term or shall we revert this PR and re-fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
eladkal merged PR #46352: URL: https://github.com/apache/airflow/pull/46352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
eladkal commented on code in PR #46352:
URL: https://github.com/apache/airflow/pull/46352#discussion_r1938485429
##
providers/oracle/tests/system/oracle/example_oracle.py:
##
@@ -0,0 +1,97 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""
+This is an example DAG for the use of the SQLExecuteQueryOperator with Oracle.
+"""
+
+from __future__ import annotations
+
+import os
+from datetime import datetime
+
+from airflow import DAG
+from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator
+
+ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
+DAG_ID = "example_oracle"
+
+with DAG(
+dag_id=DAG_ID,
+schedule=None,
+start_date=datetime(2025, 1, 1),
+default_args={"conn_id": "oracle_conn_id"},
+tags=["example"],
+catchup=False,
+) as dag:
+# [START howto_operator_oracle]
+
+# Example of creating a task that calls a common CREATE TABLE sql command.
+create_table_oracle_task = SQLExecuteQueryOperator(
+task_id="create_table_oracle",
+sql=r"""
+BEGIN
+EXECUTE IMMEDIATE '
+CREATE TABLE employees (
+id NUMBER GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
+name VARCHAR2(50),
+salary NUMBER(10, 2),
+hire_date DATE DEFAULT SYSDATE
+)';
+END;
+""",
+)
+
+# [END howto_operator_oracle]
+
+insert_data_oracle_task = SQLExecuteQueryOperator(
+task_id="insert_data_oracle",
+sql=r"""
+BEGIN
+INSERT INTO employees (name, salary) VALUES ('Alice', 5);
+INSERT INTO employees (name, salary) VALUES ('Bob', 6);
+END;
+""",
+)
+
+select_data_oracle_task = SQLExecuteQueryOperator(
+task_id="select_data_oracle",
+sql=r"""
+SELECT * FROM employees
+""",
+)
+
+# [START howto_operator_oracle_external_file]
+
+drop_table_oracle_task = SQLExecuteQueryOperator(
+task_id="drop_table_oracle",
+sql="oracle_drop_table.sql",
Review Comment:
```suggestion
sql="DROP TABLE employees",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
eladkal commented on code in PR #46352: URL: https://github.com/apache/airflow/pull/46352#discussion_r1938485367 ## providers/oracle/tests/system/oracle/oracle_drop_table.sql: ## @@ -0,0 +1,20 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +*/ + +DROP TABLE employees Review Comment: Lets not do this. it creates complexity trying to understand the docs. When viewing oracle docs you can assume users know about templating from sql file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
nailo2c commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2629267391 Thanks for the reminder! All the static check errors have been fixed. Next time, I'll remember to use `pre-commit` to check :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve example docs around SQLExecuteQueryOperator in Postgres/Oracle/Presto/Vertica/ODBC [airflow]
potiuk commented on PR #46352: URL: https://github.com/apache/airflow/pull/46352#issuecomment-2629140532 But you also need to run pre-commits :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
